content/browser/frame_host/render_widget_host_view_child_frame.cc - Issue 1304063014: cc: Plumbing for BeginFrameSource based on Surfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 1304063014: cc: Plumbing for BeginFrameSource based on Surfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More use-after-free. Attempt to fix mojo. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/surfaces/surface_unittest.cc ('K') | « content/browser/frame_host/render_widget_host_view_child_frame.h ('k') | content/browser/renderer_host/render_widget_host_view_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_widget_host_view_child_frame.cc

diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc

index 44f83df62433b765975b92ebbfecc48491dbc7e1..541cd6fe21c3e6d18f97048774a22223e1b8a6fe 100644

--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc

+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc

@@ -464,6 +464,12 @@ void RenderWidgetHostViewChildFrame::ReturnResources(

std::back_inserter(surface_returned_resources_));

}

+void RenderWidgetHostViewChildFrame::SetBeginFrameSource(

+ cc::BeginFrameSource* begin_frame_source) {

+ // TODO(tansell): Hook this up to RWHV and use an orphan BeginFrameSource if

+ // null.

BrowserAccessibilityManager*

RenderWidgetHostViewChildFrame::CreateBrowserAccessibilityManager(

BrowserAccessibilityDelegate* delegate) {