third_party/binutils/upload.sh - Issue 1368233002: Upgrading binutils to 2.25 for -ggnu-pubnames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/binutils/upload.sh

Issue 1368233002: Upgrading binutils to 2.25 for -ggnu-pubnames (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Extra details about goma. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/binutils/upload.sh

diff --git a/third_party/binutils/upload.sh b/third_party/binutils/upload.sh

index 5ff10aad3ad7029ab259bb1f447e8d23967c4e2c..31f1a06c32eaf85d1713e61168cfb15674d8674d 100755

--- a/third_party/binutils/upload.sh

+++ b/third_party/binutils/upload.sh

@@ -61,5 +61,8 @@ for DIR in $1/*; do

done

echo "Please commit the new .sha1 to the Chromium repository"

-echo ""

echo "# git commit"

+echo ""

+echo "Make sure goma is updated with the new binutils *before* landing."

+echo " Notify {ukai,yyanagisawa,shinyak}@chromium.org with the .sha1 files"

+echo " and await confirmation."

« no previous file with comments | « third_party/binutils/ehframe-race.patch ('k') | no next file » | no next file with comments »