Skip flushes on icon writes for 10x better jumplist perf

ui/gfx/icon_util.h

Index: ui/gfx/icon_util.h
diff --git a/ui/gfx/icon_util.h b/ui/gfx/icon_util.h
index 2e1c0804888955b7c13d6d0780d64e58915121b5..33b51428be057dc148e227ec5612611422fddb24 100644
--- a/ui/gfx/icon_util.h
+++ b/ui/gfx/icon_util.h
@@ -59,6 +59,7 @@ class SkBitmap;
 ///////////////////////////////////////////////////////////////////////////////
 class GFX_EXPORT IconUtil {
  public:
+  enum WriteType { ATOMIC_WRITE, NORMAL_WRITE };

[Alexei Svitkine (slow), 2015/09/30 21:26:23]

Nit: Add a comment.

[brucedawson, 2015/09/30 22:13:59]

Good point. Done.

   // The size of the large icon entries in .ico files on Windows Vista+.
   static const int kLargeIconSize = 256;
   // The size of icons in the medium icons view on Windows Vista+. This is the
@@ -127,7 +128,8 @@ class GFX_EXPORT IconUtil {
   // |image_family| is empty.
   static bool CreateIconFileFromImageFamily(
       const gfx::ImageFamily& image_family,
-      const base::FilePath& icon_path);
+      const base::FilePath& icon_path,
+      WriteType write_type = ATOMIC_WRITE);
 
   // Creates a cursor of the specified size from the DIB passed in.
   // Returns the cursor on success or NULL on failure.
@@ -140,7 +142,7 @@ class GFX_EXPORT IconUtil {
   // The icon format is published in the MSDN but there is no definition of
   // the icon file structures in any of the Windows header files so we need to
   // define these structure within the class. We must make sure we use 2 byte
-  // packing so that the structures are layed out properly within the file.
+  // packing so that the structures are laid out properly within the file.
   // See: http://msdn.microsoft.com/en-us/library/ms997538.aspx
 #pragma pack(push)
 #pragma pack(2)