Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/local_bisect.py

Issue 1573293002: Change auto_bisect to post results to perf dashboard. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: update Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/auto_bisect/local_bisect.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/local_bisect.py b/scripts/slave/recipe_modules/auto_bisect/local_bisect.py
index 518e14625d6419e847539204ec1a0b230b6b5f32..b5a429188d4264f776259137d65c8ab8c2e95f21 100644
--- a/scripts/slave/recipe_modules/auto_bisect/local_bisect.py
+++ b/scripts/slave/recipe_modules/auto_bisect/local_bisect.py
@@ -27,7 +27,7 @@ def perform_bisect(api): # pragma: no cover
else:
bisector.bisect_over = True
bisector.print_result_debug_info()
- bisector.print_result()
+ bisector.post_result(halt_on_failure=True)
def _ensure_checkout(api): # pragma: no cover
@@ -75,9 +75,7 @@ def _bisect_main_loop(bisector): # pragma: no cover
completed_revisions = []
with bisector.api.m.step.nest(str('Working on revision ' +
revisions_to_check[0].revision_string)):
- nest_step_result = bisector.api.m.step.active_result
- partial_results = bisector.partial_results().splitlines()
- nest_step_result.presentation.logs['Partial Results'] = partial_results
+ bisector.post_result(halt_on_failure=False)
RobertoCN 2016/01/12 20:47:29 At first I was concerned that we might not be show
chrisphan 2016/01/14 00:53:26 Right, I was making 'post bisect results' step gen
for r in revisions_to_check:
r.start_job()
completed_revisions = _wait_for_revisions(bisector, revisions_to_check)

Powered by Google App Engine
This is Rietveld 408576698