Serialisation code for Certificate Transparency data

Serialisation code for Certificate Transparency data

These data structures are taken from RFC6962-bis. They will be useful in
the future when signed tree heads and consistency proofs are downloaded
using the Component Updater and stored on disk.

BUG=506227

[Rob Percival, 2016-01-11 22:34:31]

Description was changed from

==========
Serialisation code for Certificate Transparency data

These data structures are taken from RFC6962-bis. They will be useful in
the future when signed tree heads and consistency proofs are downloaded
using the Component Updater and stored on disk.

BUG=506227
==========

to

==========
Serialisation code for Certificate Transparency data

These data structures are taken from RFC6962-bis. They will be useful in
the future when signed tree heads and consistency proofs are downloaded
using the Component Updater and stored on disk.

BUG=506227
==========

[Rob Percival, 2016-01-11 22:34:31]

robpercival@chromium.org changed reviewers:
+ eranm@chromium.org

[Eran Messeri, 2016-01-14 12:46:45]

https://codereview.chromium.org/1576513002/diff/1/net/cert/ct_serialization.cc
File net/cert/ct_serialization.cc (right):

https://codereview.chromium.org/1576513002/diff/1/net/cert/ct_serialization.c...
net/cert/ct_serialization.cc:427: log_id.CopyToString(&output->log_id);
A common pattern in this file is to decode to a temporary object and swap it
with |output| only if decoding succeeded.

https://codereview.chromium.org/1576513002/diff/1/net/cert/ct_serialization.h
File net/cert/ct_serialization.h (right):

https://codereview.chromium.org/1576513002/diff/1/net/cert/ct_serialization.h...
net/cert/ct_serialization.h:24: struct TransItem;
Unnecessary as you're including ct_trans_item.h

https://codereview.chromium.org/1576513002/diff/1/net/cert/ct_serialization.h...
net/cert/ct_serialization.h:88: NET_EXPORT_PRIVATE bool
DecodeSignedTreeHead(base::StringPiece* input,
Comment that all of these are from RFC6962-bis, not RFC6962 (i.e. RFC6962 does
not need TLS encoding of these structures).

https://codereview.chromium.org/1576513002/diff/1/net/cert/signed_tree_head.cc
File net/cert/signed_tree_head.cc (right):

https://codereview.chromium.org/1576513002/diff/1/net/cert/signed_tree_head.c...
net/cert/signed_tree_head.cc:25: strncpy(this->sha256_root_hash,
sha256_root_hash, kSthRootHashLength);
You should use memcpy - strncpy breaks if there's a null character in the source
string.

https://codereview.chromium.org/1576513002/diff/1/net/test/ct_test_util.cc
File net/test/ct_test_util.cc (right):

https://codereview.chromium.org/1576513002/diff/1/net/test/ct_test_util.cc#ne...
net/test/ct_test_util.cc:287: const std::string
timestamp("\x0\x0\x1\x45\x3c\x5f\xb8\x35", 8);
Why not use the encoding functions you've added to avoid manually encoding these
values?

https://codereview.chromium.org/1576513002/diff/1/net/test/ct_test_util.h
File net/test/ct_test_util.h (right):

https://codereview.chromium.org/1576513002/diff/1/net/test/ct_test_util.h#new...
net/test/ct_test_util.h:85: std::string GetSampleSTH();
Since it belongs to RFC6962-bis the function name should reflect it -
GetSampleSTHDataV1?

[Eran Messeri, 2016-05-03 09:47:31]

eranm@chromium.org changed reviewers:
- eranm@chromium.org