Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/auto_bisect/bisect_results.py

Issue 1625573004: Update legacy bisect to post results to perf dashboard. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_import_path
Patch Set: update Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/auto_bisect/bisect_perf_regression_test.py ('k') | tools/auto_bisect/bisect_results_json.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/auto_bisect/bisect_results.py
diff --git a/tools/auto_bisect/bisect_results.py b/tools/auto_bisect/bisect_results.py
index f6ba0d856d54860e9ce86f3ff84a661085ce86ee..094d107576f3bc34906dfdeacd739ed611b28b95 100644
--- a/tools/auto_bisect/bisect_results.py
+++ b/tools/auto_bisect/bisect_results.py
@@ -56,6 +56,13 @@ class BisectResults(object):
runtime_warnings: A list of warnings from the bisect run.
error: Error message. When error is not None, other arguments are ignored.
"""
+ # Setting these attributes so that bisect printer does not break when the
+ # regression cannot be reproduced (no broken revision was found)
+ self.regression_size = 0
+ self.regression_std_err = 0
+ self.confidence = 0
+ self.culprit_revisions = []
+
self.error = error
self.abort_reason = abort_reason
if error is not None or abort_reason is not None:
@@ -91,13 +98,6 @@ class BisectResults(object):
self.warnings += self._GetResultBasedWarnings(
self.culprit_revisions, opts, self.confidence)
- elif first_working_rev is not None:
- # Setting these attributes so that bisect printer does not break when the
- # regression cannot be reproduced (no broken revision was found)
- self.regression_size = 0
- self.regression_std_err = 0
- self.confidence = 0
- self.culprit_revisions = []
def AddRetestResults(self, results_tot, results_reverted):
if not results_tot or not results_reverted:
« no previous file with comments | « tools/auto_bisect/bisect_perf_regression_test.py ('k') | tools/auto_bisect/bisect_results_json.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698