Chromium Code Reviews Chromium Code Reviews
Issue 1771023002:
Fix missing message-bar Element on /report and /alerts page. (Closed)
Base URL: https://github.com/catapult-project/catapult.git@master| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <!-- | 2 <!-- |
| 3 Copyright 2016 The Chromium Authors. All rights reserved. | 3 Copyright 2016 The Chromium Authors. All rights reserved. |
| 4 Use of this source code is governed by a BSD-style license that can be | 4 Use of this source code is governed by a BSD-style license that can be |
| 5 found in the LICENSE file. | 5 found in the LICENSE file. |
| 6 --> | 6 --> |
| 7 <html> | 7 <html> |
| 8 <head> | 8 <head> |
| 9 <link type="text/css" rel="stylesheet" href="/dashboard/static/base.css"> | 9 <link type="text/css" rel="stylesheet" href="/dashboard/static/base.css"> |
| 10 | 10 |
| 11 <script src="/jquery/jquery-2.1.4.min.js"></script> | 11 <script src="/jquery/jquery-2.1.4.min.js"></script> |
| 12 <script src="/flot/jquery.flot.min.js"></script> | 12 <script src="/flot/jquery.flot.min.js"></script> |
| 13 <script src="/flot/jquery.flot.crosshair.min.js"></script> | 13 <script src="/flot/jquery.flot.crosshair.min.js"></script> |
| 14 <script src="/flot/jquery.flot.fillbetween.min.js"></script> | 14 <script src="/flot/jquery.flot.fillbetween.min.js"></script> |
| 15 <script src="/flot/jquery.flot.selection.min.js"></script> | 15 <script src="/flot/jquery.flot.selection.min.js"></script> |
| 16 | 16 |
| 17 <link rel="import" href="/components/polymer/polymer.html"> | 17 <link rel="import" href="/components/polymer/polymer.html"> |
| 18 | 18 |
| 19 <link rel="import" href="/dashboard/elements/load-analytics.html"> | 19 <link rel="import" href="/dashboard/elements/load-analytics.html"> |
| 20 <link rel="import" href="/dashboard/elements/nav-bar.html"> | 20 <link rel="import" href="/dashboard/elements/nav-bar.html"> |
| 21 <link rel="import" href="/dashboard/elements/overlay-message.html"> | 21 <link rel="import" href="/dashboard/elements/overlay-message.html"> |
| 22 <link rel="import" href="/dashboard/elements/report-page.html"> | 22 <link rel="import" href="/dashboard/elements/report-page.html"> |
| 23 | 23 |
| 24 <title>Chrome Performance Dashboard</title> | 24 <style> |
|
sullivan
2016/03/07 23:01:29
Why remove the title?
chrisphan
2016/03/08 01:55:48
Woops, added it's back.
| |
| 25 #message-bar { | |
| 26 top: 26px; | |
| 27 } | |
| 28 </style> | |
| 25 | 29 |
| 26 <script> | 30 <script> |
| 27 'use strict'; | 31 'use strict'; |
| 28 // Workaround for document.contains returning false for elements in the | 32 // Workaround for document.contains returning false for elements in the |
| 29 // shadow DOM. jQuery mouse events need it to return true for scrolling | 33 // shadow DOM. jQuery mouse events need it to return true for scrolling |
| 30 // to be properly accounted for. For background, see | 34 // to be properly accounted for. For background, see |
| 31 // https://github.com/Polymer/polymer/issues/162 and | 35 // https://github.com/Polymer/polymer/issues/162 and |
| 32 // https://www.w3.org/Bugs/Public/show_bug.cgi?id=22141 | 36 // https://www.w3.org/Bugs/Public/show_bug.cgi?id=22141 |
| 33 jQuery.contains = function(doc, elem) { | 37 jQuery.contains = function(doc, elem) { |
| 34 var charts = document.getElementsByTagName('report-page')[0].charts; | 38 var charts = document.getElementsByTagName('report-page')[0].charts; |
| 35 for (var i = 0; i < charts.length; i++) { | 39 for (var i = 0; i < charts.length; i++) { |
| 36 if (charts[i].shadowRoot.contains(elem)) { | 40 if (charts[i].shadowRoot.contains(elem)) { |
| 37 return true; | 41 return true; |
| 38 } | 42 } |
| 39 } | 43 } |
| 40 return doc.contains(elem); | 44 return doc.contains(elem); |
| 41 }; | 45 }; |
| 42 </script> | 46 </script> |
| 43 </head> | 47 </head> |
| 44 <body> | 48 <body> |
| 45 <nav-bar></nav-bar> | 49 <nav-bar></nav-bar> |
| 46 <h1>Chrome Performance Dashboard</h1> | 50 <h1>Chrome Performance Dashboard</h1> |
| 51 <overlay-message id="message-bar"></overlay-message> | |
| 47 <report-page></report-page> | 52 <report-page></report-page> |
| 48 <load-analytics></load-analytics> | 53 <load-analytics></load-analytics> |
| 49 </body> | 54 </body> |
| 50 </html> | 55 </html> |
| OLD | NEW |
