dashboard/dashboard/static/alerts.html - Issue 1771023002: Fix missing message-bar Element on /report and /alerts page.

Unified Diff: dashboard/dashboard/static/alerts.html

Issue 1771023002: Fix missing message-bar Element on /report and /alerts page. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dashboard/dashboard/static/alerts.html

diff --git a/dashboard/dashboard/static/alerts.html b/dashboard/dashboard/static/alerts.html

index 4ceacd559aeec2d99835f87ccfe0b06e93e749b4..8459cde9c461408a99bf7ce2bf95f2c74fd81c4b 100644

--- a/dashboard/dashboard/static/alerts.html

+++ b/dashboard/dashboard/static/alerts.html

Use of this source code is governed by a BSD-style license that can be

found in the LICENSE file.

-->

+<html>

+ <head>

qyearsley 2016/03/07 23:47:29 Adding a html, head and body looks reasonable but

chrisphan 2016/03/08 01:55:48 It works without them. Browsers are pretty smart

+ <link type="text/css" rel="stylesheet" href="/dashboard/static/base.css">

-<link type="text/css" rel="stylesheet" href="/dashboard/static/base.css">

+ <link rel="import" href="/components/polymer/polymer.html">

-<link rel="import" href="/components/polymer/polymer.html">

+ <link rel="import" href="/dashboard/elements/alerts-page.html">

+ <link rel="import" href="/dashboard/elements/load-analytics.html">

+ <link rel="import" href="/dashboard/elements/nav-bar.html">

+ <link rel="import" href="/dashboard/static/uri.html">

-<link rel="import" href="/dashboard/elements/alerts-page.html">

-<link rel="import" href="/dashboard/elements/load-analytics.html">

-<link rel="import" href="/dashboard/elements/nav-bar.html">

-<link rel="import" href="/dashboard/static/uri.html">

+ <style>

+ #message-bar {

+ top: 26px;

+ }

+ </style>

+ </head>

-<nav-bar></nav-bar>

-<script>

- 'use strict';

- // The Google analytics code assumes there will be a script element to

- // inject into in the page. This empty element is used for that.

-</script>

-<h1>Chrome Performance Alerts</h1>

-<alerts-page></alerts-page>

-<load-analytics></load-analytics>

+ <body>

+ <nav-bar></nav-bar>

+ <h1>Chrome Performance Alerts</h1>

+ <overlay-message id="message-bar"></overlay-message>

+ <alerts-page></alerts-page>

+ <load-analytics></load-analytics>

+ <script>

+ 'use strict';

+ // The Google analytics code assumes there will be a script element to

+ // inject into in the page. This empty element is used for that.

+ </script>

+ </body>

+</html>

« no previous file with comments | « dashboard/dashboard/elements/alerts-page.html ('k') | dashboard/dashboard/static/report.html » ('j') | dashboard/dashboard/static/report.html » ('J')