Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: tools/run-bisect-perf-regression.py

Issue 1823803004: Add 'try_job_id' to bisect option. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add try_job_id to run-bisect-perf-regression.py Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/auto_bisect/bisect_perf_regression.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Run Performance Test Bisect Tool 6 """Run Performance Test Bisect Tool
7 7
8 This script is used by a try bot to run the bisect script with the parameters 8 This script is used by a try bot to run the bisect script with the parameters
9 specified in the bisect config file. It checks out a copy of the depot in 9 specified in the bisect config file. It checks out a copy of the depot in
10 a subdirectory 'bisect' of the working directory provided, annd runs the 10 a subdirectory 'bisect' of the working directory provided, annd runs the
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 if config.has_key('required_initial_confidence'): 213 if config.has_key('required_initial_confidence'):
214 opts_dict['required_initial_confidence'] = float( 214 opts_dict['required_initial_confidence'] = float(
215 config['required_initial_confidence']) 215 config['required_initial_confidence'])
216 216
217 if config.has_key('target_arch'): 217 if config.has_key('target_arch'):
218 opts_dict['target_arch'] = config['target_arch'] 218 opts_dict['target_arch'] = config['target_arch']
219 219
220 if config.has_key('bug_id') and str(config['bug_id']).isdigit(): 220 if config.has_key('bug_id') and str(config['bug_id']).isdigit():
221 opts_dict['bug_id'] = config['bug_id'] 221 opts_dict['bug_id'] = config['bug_id']
222 222
223 if config.has_key('try_job_id'):
224 opts_dict['try_job_id'] = config['try_job_id']
225
223 opts_dict['build_preference'] = 'ninja' 226 opts_dict['build_preference'] = 'ninja'
224 opts_dict['output_buildbot_annotations'] = True 227 opts_dict['output_buildbot_annotations'] = True
225 228
226 if '--browser=cros' in config['command']: 229 if '--browser=cros' in config['command']:
227 opts_dict['target_platform'] = 'cros' 230 opts_dict['target_platform'] = 'cros'
228 231
229 if os.environ[CROS_BOARD_ENV] and os.environ[CROS_IP_ENV]: 232 if os.environ[CROS_BOARD_ENV] and os.environ[CROS_IP_ENV]:
230 opts_dict['cros_board'] = os.environ[CROS_BOARD_ENV] 233 opts_dict['cros_board'] = os.environ[CROS_BOARD_ENV]
231 opts_dict['cros_remote_ip'] = os.environ[CROS_IP_ENV] 234 opts_dict['cros_remote_ip'] = os.environ[CROS_IP_ENV]
232 else: 235 else:
(...skipping 287 matching lines...) Expand 10 before | Expand all | Expand 10 after
520 523
521 # Add flags for any optional config parameters if given in the config. 524 # Add flags for any optional config parameters if given in the config.
522 options = [ 525 options = [
523 ('metric', '--metric'), 526 ('metric', '--metric'),
524 ('repeat_count', '--repeat_test_count'), 527 ('repeat_count', '--repeat_test_count'),
525 ('truncate_percent', '--truncate_percent'), 528 ('truncate_percent', '--truncate_percent'),
526 ('max_time_minutes', '--max_time_minutes'), 529 ('max_time_minutes', '--max_time_minutes'),
527 ('bisect_mode', '--bisect_mode'), 530 ('bisect_mode', '--bisect_mode'),
528 ('improvement_direction', '--improvement_direction'), 531 ('improvement_direction', '--improvement_direction'),
529 ('bug_id', '--bug_id'), 532 ('bug_id', '--bug_id'),
533 ('try_job_id', '--try_job_id'),
530 ('builder_type', '--builder_type'), 534 ('builder_type', '--builder_type'),
531 ('target_arch', '--target_arch'), 535 ('target_arch', '--target_arch'),
532 ('required_initial_confidence', '--required_initial_confidence'), 536 ('required_initial_confidence', '--required_initial_confidence'),
533 ] 537 ]
534 for config_key, flag in options: 538 for config_key, flag in options:
535 if config.has_key(config_key): 539 if config.has_key(config_key):
536 cmd.extend([flag, config[config_key]]) 540 cmd.extend([flag, config[config_key]])
537 541
538 cmd.extend(['--build_preference', 'ninja']) 542 cmd.extend(['--build_preference', 'ninja'])
539 543
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
873 return _SetupAndRunPerformanceTest( 877 return _SetupAndRunPerformanceTest(
874 config={}, path_to_goma=opts.path_to_goma, is_cq_tryjob=True) 878 config={}, path_to_goma=opts.path_to_goma, is_cq_tryjob=True)
875 879
876 print ('Error: Could not load config file. Double check your changes to ' 880 print ('Error: Could not load config file. Double check your changes to '
877 'auto_bisect/bisect.cfg or run-perf-test.cfg for syntax errors.\n') 881 'auto_bisect/bisect.cfg or run-perf-test.cfg for syntax errors.\n')
878 return 1 882 return 1
879 883
880 884
881 if __name__ == '__main__': 885 if __name__ == '__main__':
882 sys.exit(main()) 886 sys.exit(main())
OLDNEW
« no previous file with comments | « tools/auto_bisect/bisect_perf_regression.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698