Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: components/certificate_transparency/log_dns_client.h

Issue 2331923003: Allow LogDnsClient queries to be rate-limited (Closed)
Patch Set: Set LogDnsClient max_concurrent_queries via constructor param Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/certificate_transparency/log_dns_client.h
diff --git a/components/certificate_transparency/log_dns_client.h b/components/certificate_transparency/log_dns_client.h
index 366702925c619ec1809ded8d3931ab9f806e5c36..6c561b072e78ceee9ecce1dfe8d77a06a8256503 100644
--- a/components/certificate_transparency/log_dns_client.h
+++ b/components/certificate_transparency/log_dns_client.h
@@ -52,8 +52,13 @@ class LogDnsClient : public net::NetworkChangeNotifier::DNSObserver {
// to perform DNS queries. Queries will be logged to |net_log|.
// The |dns_client| does not need to be configured first - this will be done
// automatically as needed.
+ // A limit can be set on the number of concurrent DNS queries by providing a
+ // positive value for |max_concurrent_queries|. Queries that would exceed this
+ // limit will fail with net::TEMPORARILY_THROTTLED. Setting this to 0 will
+ // disable this limit.
LogDnsClient(std::unique_ptr<net::DnsClient> dns_client,
- const net::BoundNetLog& net_log);
+ const net::BoundNetLog& net_log,
+ size_t max_concurrent_queries);
// Must be deleted on the same thread that it was created on.
~LogDnsClient() override;
@@ -108,6 +113,11 @@ class LogDnsClient : public net::NetworkChangeNotifier::DNSObserver {
int net_error,
const net::DnsResponse* response);
+ // Returns true if the maximum number of queries are currently in flight.
+ // If the maximum number of concurrency queries is set to 0, this will always
+ // return false.
+ bool HasMaxConcurrentQueriesInProgress() const;
Ryan Sleevi 2016/09/12 18:12:43 +1 to comment about use case
Rob Percival 2016/09/13 14:06:31 There was no comment about the use case of this me
+
// Updates the |dns_client_| config using NetworkChangeNotifier.
void UpdateDnsConfig();
@@ -126,6 +136,8 @@ class LogDnsClient : public net::NetworkChangeNotifier::DNSObserver {
std::list<Query<LeafIndexCallback>> leaf_index_queries_;
// Audit proof queries that haven't completed yet.
std::list<Query<AuditProofCallback>> audit_proof_queries_;
+ // The maximum number of queries that can be in flight at one time.
+ size_t max_concurrent_queries_;
// Creates weak_ptrs to this, for callback purposes.
base::WeakPtrFactory<LogDnsClient> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698