Prefer overridden dependencies.

Prefer overridden dependencies.

Currently, when overriding packages, the overridden packages must still
declare the same dependency versions as regular packages. This requires
the user to sync everything prior to experimenting with cross-repository
patches.

Change this behavior to make it so that overridden packages' dependency
set is preferred to the root package's dependencies. This creates a
functional illusion that the overridden packages have been rolled, and
that the root package is being considered candidate for rolling, which
is useful for developers.

BUG=None
TEST=local
  - Ran unit tests.
  - Ran against overridden dependencies with inconsistent dependency
    trees.

Committed: https://github.com/luci/recipes-py/commit/f7ada90c926c78704f048767e29e8ae836d8a65b

[dnj, 2016-09-15 21:45:36]

dnj@chromium.org changed reviewers:
+ martiniss@chromium.org

[dnj, 2016-09-15 21:45:37]

PTAL. This should have the effect of making "-O" intuitively behave like a roll
for the specified override(s) happened and you're running in that space.

[dnj, 2016-09-15 22:15:57]

dnj@chromium.org changed reviewers:
+ iannucci@chromium.org

[dnj, 2016-09-15 22:15:57]

+iannucci@, FYI

[iannucci, 2016-09-16 07:17:20]

iannucci@chromium.org changed required reviewers:
+ martiniss@chromium.org

[iannucci, 2016-09-16 07:17:21]

lgtm, though martiniss should definitely take a look too.

https://chromiumcodereview.appspot.com/2343733003/diff/1/recipe_engine/packag...
File recipe_engine/package.py (right):

https://chromiumcodereview.appspot.com/2343733003/diff/1/recipe_engine/packag...
recipe_engine/package.py:656: # flow.
can remove this comment I think. inconsistent graph is an exceptional condition.
Handling an error doesn't count as 'using exceptions for control flow'.

[dnj, 2016-09-16 22:32:05]

https://codereview.chromium.org/2343733003/diff/1/recipe_engine/package.py
File recipe_engine/package.py (right):

https://codereview.chromium.org/2343733003/diff/1/recipe_engine/package.py#ne...
recipe_engine/package.py:656: # flow.
On 2016/09/16 07:17:21, iannucci wrote:
> can remove this comment I think. inconsistent graph is an exceptional
condition.
> Handling an error doesn't count as 'using exceptions for control flow'.

Done.

[dnj, 2016-09-16 22:32:41]

The CQ bit was checked by dnj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 22:32:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 22:38:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 22:38:01]

Dry run: This issue passed the CQ dry run.

[dnj, 2016-09-19 16:56:44]

(ping)

[martiniss, 2016-09-19 19:07:42]

lgtm

https://codereview.chromium.org/2343733003/diff/20001/recipe_engine/package.py
File recipe_engine/package.py (right):

https://codereview.chromium.org/2343733003/diff/20001/recipe_engine/package.p...
recipe_engine/package.py:642: def _create_package(self, package_id, repo_spec,
overriding):
nit: unused argument package_id

[dnj, 2016-09-19 20:43:50]

https://codereview.chromium.org/2343733003/diff/20001/recipe_engine/package.py
File recipe_engine/package.py (right):

https://codereview.chromium.org/2343733003/diff/20001/recipe_engine/package.p...
recipe_engine/package.py:642: def _create_package(self, package_id, repo_spec,
overriding):
On 2016/09/19 19:07:42, martiniss wrote:
> nit: unused argument package_id

Done.

[dnj, 2016-09-19 21:45:26]

The CQ bit was checked by dnj@chromium.org

[dnj, 2016-09-19 21:45:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org, martiniss@chromium.org
Link to the patchset: https://codereview.chromium.org/2343733003/#ps40001
(title: "Removed unused argument.")

[commit-bot: I haz the power, 2016-09-19 21:45:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 21:50:53]

Description was changed from

==========
Prefer overridden dependencies.

Currently, when overriding packages, the overridden packages must still
declare the same dependency versions as regular packages. This requires
the user to sync everything prior to experimenting with cross-repository
patches.

Change this behavior to make it so that overridden packages' dependency
set is preferred to the root package's dependencies. This creates a
functional illusion that the overridden packages have been rolled, and
that the root package is being considered candidate for rolling, which
is useful for developers.

BUG=None
TEST=local
  - Ran unit tests.
  - Ran against overridden dependencies with inconsistent dependency
    trees.
==========

to

==========
Prefer overridden dependencies.

Currently, when overriding packages, the overridden packages must still
declare the same dependency versions as regular packages. This requires
the user to sync everything prior to experimenting with cross-repository
patches.

Change this behavior to make it so that overridden packages' dependency
set is preferred to the root package's dependencies. This creates a
functional illusion that the overridden packages have been rolled, and
that the root package is being considered candidate for rolling, which
is useful for developers.

BUG=None
TEST=local
  - Ran unit tests.
  - Ran against overridden dependencies with inconsistent dependency
    trees.

Committed:
https://github.com/luci/recipes-py/commit/f7ada90c926c78704f048767e29e8ae836d...
==========

[commit-bot: I haz the power, 2016-09-19 21:50:54]

Committed patchset #3 (id:40001) as
https://github.com/luci/recipes-py/commit/f7ada90c926c78704f048767e29e8ae836d...