Put a hard limit on initial policy fetch wait time.

Put a hard limit on initial policy fetch wait time.

This assures that we're not hanging for a long time at login on the
initial policy fetch for Chrome OS user policy to happen.

BUG=chromium:285694
TEST=See bug, unit tests.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221723

[Mattias Nissler (ping if slow), 2013-09-05 17:57:05]

Please review!

[Mattias Nissler (ping if slow), 2013-09-06 10:58:19]

Joao is out. Drew, can you review?

[Andrew T Wilson (Slow), 2013-09-06 12:33:45]

lgtm

https://chromiumcodereview-hr.appspot.com/23450022/diff/5001/chrome/browser/c...
File chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc
(right):

https://chromiumcodereview-hr.appspot.com/23450022/diff/5001/chrome/browser/c...
chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc:257:
return;
This is fine as-is. Alternatively, you could also stop the timer and then you
wouldn't have to do this check?

https://chromiumcodereview-hr.appspot.com/23450022/diff/5001/chrome/browser/c...
File
chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc
(right):

https://chromiumcodereview-hr.appspot.com/23450022/diff/5001/chrome/browser/c...
chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc:48:
const int kInitialPolicyFetchTimeout = 10;
nit: for time values, I usually like to put the time unit in the constant name
(e.g. kInitialPolicyFetchTimeoutSecs)

[Mattias Nissler (ping if slow), 2013-09-06 13:37:30]

https://chromiumcodereview-hr.appspot.com/23450022/diff/5001/chrome/browser/c...
File chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc
(right):

https://chromiumcodereview-hr.appspot.com/23450022/diff/5001/chrome/browser/c...
chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc:257:
return;
On 2013/09/06 12:33:45, Andrew T Wilson wrote:
> This is fine as-is. Alternatively, you could also stop the timer and then you
> wouldn't have to do this check?

This is better, there are already other code paths that might result in
CancelWaitForPolicyFetch() being called multiple teams (for example, via
OnClientError).

https://chromiumcodereview-hr.appspot.com/23450022/diff/5001/chrome/browser/c...
File
chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc
(right):

https://chromiumcodereview-hr.appspot.com/23450022/diff/5001/chrome/browser/c...
chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc:48:
const int kInitialPolicyFetchTimeout = 10;
On 2013/09/06 12:33:45, Andrew T Wilson wrote:
> nit: for time values, I usually like to put the time unit in the constant name
> (e.g. kInitialPolicyFetchTimeoutSecs)

Good point, done.

[commit-bot: I haz the power, 2013-09-06 14:53:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/23450022/12001

[commit-bot: I haz the power, 2013-09-06 17:25:14]

Change committed as 221723