Consolidate TestURLFetcherFactory::SetFakeResponse

chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 #include <queue>
 #include <string>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/time/time.h"
 #include "chrome/browser/safe_browsing/client_side_detection_service.h"
 #include "chrome/common/safe_browsing/client_model.pb.h"
 #include "chrome/common/safe_browsing/csd.pb.h"
 #include "content/public/test/test_browser_thread.h"
 #include "crypto/sha2.h"
 #include "net/url_request/test_url_fetcher_factory.h"
 #include "net/url_request/url_request_status.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
-using ::testing::_;
 using ::testing::Invoke;
 using ::testing::Mock;
 using ::testing::StrictMock;
+using ::testing::_;
 using content::BrowserThread;
 
 namespace safe_browsing {
 namespace {
 class MockClientSideDetectionService : public ClientSideDetectionService {
  public:
   MockClientSideDetectionService() : ClientSideDetectionService(NULL) {}
   virtual ~MockClientSideDetectionService() {}
 
   MOCK_METHOD1(EndFetchModel, void(ClientModelStatus));
@@ skipping 59 matching lines @@
     csd_service_->SendClientReportMalwareRequest(
         request.release(),
         base::Bind(&ClientSideDetectionServiceTest::SendMalwareRequestDone,
                    base::Unretained(this)));
     phishing_url_ = url;
     msg_loop_.Run();  // Waits until callback is called.
     return is_malware_;
   }
 
   void SetModelFetchResponse(std::string response_data, bool success) {
-    factory_->SetFakeResponse(ClientSideDetectionService::kClientModelUrl,
+    factory_->SetFakeResponse(GURL(ClientSideDetectionService::kClientModelUrl),
                               response_data, success);
   }
 
   void SetClientReportPhishingResponse(std::string response_data,
                                        bool success) {
     factory_->SetFakeResponse(
         ClientSideDetectionService::GetClientReportUrl(
             ClientSideDetectionService::kClientReportPhishingUrl),
         response_data, success);
   }
@@ skipping 629 matching lines @@
   EXPECT_CALL(*service, ScheduleFetchModel(_))
       .WillOnce(Invoke(service, &MockClientSideDetectionService::Schedule));
   EXPECT_CALL(*service, EndFetchModel(
       ClientSideDetectionService::MODEL_NOT_CHANGED))
       .WillOnce(Invoke(service, &MockClientSideDetectionService::Disable));
   csd_service_->SetEnabledAndRefreshState(true);
   EXPECT_FALSE(SendClientReportPhishingRequest(GURL("http://a.com/"), 0.4f));
   Mock::VerifyAndClearExpectations(service);
 }
 }  // namespace safe_browsing