chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc - Issue 23625015: Consolidate TestURLFetcherFactory::SetFakeResponse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc

Issue 23625015: Consolidate TestURLFetcherFactory::SetFakeResponse (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/local_discovery/cloud_print_printer_list_unittest.cc ('k') | chrome/browser/profile_resetter/profile_resetter_unittest.cc » ('j') | chrome/browser/safe_browsing/client_side_detection_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc

diff --git a/chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc b/chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc

index cd0caf1ae9b72d51fed0148c92ef0db1c5c7443b..afc8d61f27a6308537189d15c86dfc63a1282a74 100644

--- a/chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc

+++ b/chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc

@@ -104,7 +104,7 @@ IN_PROC_BROWSER_TEST_F(NotificationBitmapFetcherBrowserTest,

NotificationBitmapFetcher fetcher(url, &delegate);

- url_fetcher_factory_->SetFakeResponse(url.spec(), image_string, true);

+ url_fetcher_factory_->SetFakeResponse(url, image_string, true);

// We expect that the image decoder will get called and return

// an image in a callback to OnImageDecoded().

@@ -154,7 +154,7 @@ IN_PROC_BROWSER_TEST_F(NotificationBitmapFetcherBrowserTest,

NotificationBitmapFetcher fetcher(url, &delegate);

- url_fetcher_factory_->SetFakeResponse(url.spec(), std::string(), false);

+ url_fetcher_factory_->SetFakeResponse(url, std::string(), false);

fetcher.Start(browser()->profile());

@@ -170,7 +170,7 @@ IN_PROC_BROWSER_TEST_F(NotificationBitmapFetcherBrowserTest,

NotificationBitmapFetcherTestDelegate delegate(kAsyncCall);

NotificationBitmapFetcher fetcher(url, &delegate);

url_fetcher_factory_->SetFakeResponse(

- url.spec(), std::string("Not a real bitmap"), true);

+ url, std::string("Not a real bitmap"), true);

fetcher.Start(browser()->profile());