chrome/browser/safe_browsing/client_side_detection_service.h - Issue 23625015: Consolidate TestURLFetcherFactory::SetFakeResponse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service.h

Issue 23625015: Consolidate TestURLFetcherFactory::SetFakeResponse (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/client_side_detection_service.h

diff --git a/chrome/browser/safe_browsing/client_side_detection_service.h b/chrome/browser/safe_browsing/client_side_detection_service.h

index e442de6a8500968044f69bb891cc6369092658d6..cbb1a979db46b1fe7600a98dc2a28125a836d07e 100644

--- a/chrome/browser/safe_browsing/client_side_detection_service.h

+++ b/chrome/browser/safe_browsing/client_side_detection_service.h

@@ -286,7 +286,7 @@ class ClientSideDetectionService : public net::URLFetcherDelegate,

static bool ModelHasValidHashIds(const ClientSideModel& model);

// Returns the URL that will be used for phishing requests.

- static std::string GetClientReportUrl(const std::string& report_url);

+ static GURL GetClientReportUrl(const std::string& report_url);

// Whether the service is running or not. When the service is not running,

// it won't download the model nor report detected phishing URLs.

@@ -343,6 +343,6 @@ class ClientSideDetectionService : public net::URLFetcherDelegate,

DISALLOW_COPY_AND_ASSIGN(ClientSideDetectionService);

};

-} // namepsace safe_browsing

+} // namespace safe_browsing

#endif // CHROME_BROWSER_SAFE_BROWSING_CLIENT_SIDE_DETECTION_SERVICE_H_