chrome/browser/safe_browsing/client_side_detection_service_unittest.cc - Issue 23625015: Consolidate TestURLFetcherFactory::SetFakeResponse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

Issue 23625015: Consolidate TestURLFetcherFactory::SetFakeResponse (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Could have spelled it Cloud... Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/client_side_detection_service.cc ('K') | « chrome/browser/safe_browsing/client_side_detection_service.cc ('k') | chrome/browser/safe_browsing/download_protection_service.h » ('j') | chrome/browser/safe_browsing/download_protection_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

index 70a18edd484d89acae7c4ade4cf2c4f1e7aff9b7..e32dcc45e45b2ca4e9187cf627ec01f469711c0b 100644

--- a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

@@ -23,10 +23,10 @@

#include "testing/gtest/include/gtest/gtest.h"

#include "url/gurl.h"

-using ::testing::_;

using ::testing::Invoke;

using ::testing::Mock;

using ::testing::StrictMock;

+using ::testing::_;

using content::BrowserThread;

namespace safe_browsing {

@@ -106,7 +106,7 @@ class ClientSideDetectionServiceTest : public testing::Test {

}

void SetModelFetchResponse(std::string response_data, bool success) {

- factory_->SetFakeResponse(ClientSideDetectionService::kClientModelUrl,

+ factory_->SetFakeResponse(GURL(ClientSideDetectionService::kClientModelUrl),

response_data, success);

}