Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7081)

Unified Diff: chrome/browser/ui/search/instant_extended_interactive_uitest.cc

Issue 23625015: Consolidate TestURLFetcherFactory::SetFakeResponse (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Could have spelled it Cloud... Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/instant_extended_interactive_uitest.cc
diff --git a/chrome/browser/ui/search/instant_extended_interactive_uitest.cc b/chrome/browser/ui/search/instant_extended_interactive_uitest.cc
index 2459c6cdfd9df326db489e3e6188a1d15c269dee..eee2093144d1c9abda9f0657638bc960baa1bfa3 100644
--- a/chrome/browser/ui/search/instant_extended_interactive_uitest.cc
+++ b/chrome/browser/ui/search/instant_extended_interactive_uitest.cc
@@ -1183,7 +1183,7 @@ IN_PROC_BROWSER_TEST_F(InstantExtendedTest,
content::WindowedNotificationObserver observer_2(
chrome::NOTIFICATION_INSTANT_TAB_SUPPORT_DETERMINED,
content::NotificationService::AllSources());
- SetOmniboxText(instant_url().spec() + "#q=puppies");
+ SetOmniboxText(instant_url().Resolve("#q=puppies").spec());
PressEnterAndWaitForNavigation();
observer_2.Wait();
@@ -1706,7 +1706,7 @@ IN_PROC_BROWSER_TEST_F(InstantExtendedPrefetchTest, SetPrefetchQuery) {
// Set the fake response for suggest request. Response has prefetch details.
// Ensure that the page received the prefetch query.
fake_factory()->SetFakeResponse(
- instant_url().spec() + "#q=pupp",
+ instant_url().Resolve("#q=pupp"),
"[\"pupp\",[\"puppy\", \"puppies\"],[],[],"
"{\"google:clientdata\":{\"phi\": 0},"
"\"google:suggesttype\":[\"QUERY\", \"QUERY\"],"
@@ -1752,7 +1752,7 @@ IN_PROC_BROWSER_TEST_F(InstantExtendedPrefetchTest, ClearPrefetchedResults) {
// details. Ensure that the page received a blank query to clear the
// prefetched results.
fake_factory()->SetFakeResponse(
- instant_url().spec() + "#q=dogs",
+ instant_url().Resolve("#q=dogs"),
"[\"dogs\",[\"https://dogs.com\"],[],[],"
"{\"google:suggesttype\":[\"NAVIGATION\"],"
"\"google:suggestrelevance\":[2]}]",

Powered by Google App Engine
This is Rietveld 408576698