Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/url_request/test_url_fetcher_factory.h

Issue 23625015: Consolidate TestURLFetcherFactory::SetFakeResponse (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Could have spelled it Cloud... Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/signin/signin_browsertest.cc ('K') | « chrome/service/cloud_print/printer_job_handler_unittest.cc ('k') | net/url_request/test_url_fetcher_factory.cc » ('j') | remoting/host/token_validator_factory_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/test_url_fetcher_factory.h
diff --git a/net/url_request/test_url_fetcher_factory.h b/net/url_request/test_url_fetcher_factory.h
index 35b4607f995c8f52fd561cad64d624311dff4b8b..79f315622260175bf3f6439bcea5a4ba676def61 100644
--- a/net/url_request/test_url_fetcher_factory.h
+++ b/net/url_request/test_url_fetcher_factory.h
@@ -377,13 +377,7 @@ class FakeURLFetcherFactory : public URLFetcherFactory,
// Sets the fake response for a given URL. If success is true we will serve
// an HTTP/200 and an HTTP/500 otherwise. The |response_data| may be empty.
- void SetFakeResponseForURL(const GURL& url,
- const std::string& response_data,
- bool success);
-
- // Convenience helper that calls SetFakeResponseForURL with GURL(url).
- // TODO(mnissler): Convert callers to SetFakeResponseForURL.
- void SetFakeResponse(const std::string& url,
+ void SetFakeResponse(const GURL& url,
const std::string& response_data,
bool success);
« chrome/browser/signin/signin_browsertest.cc ('K') | « chrome/service/cloud_print/printer_job_handler_unittest.cc ('k') | net/url_request/test_url_fetcher_factory.cc » ('j') | remoting/host/token_validator_factory_impl_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698