remoting/host/token_validator_factory_impl_unittest.cc - Issue 23625015: Consolidate TestURLFetcherFactory::SetFakeResponse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/token_validator_factory_impl_unittest.cc

Issue 23625015: Consolidate TestURLFetcherFactory::SetFakeResponse (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/host/token_validator_factory_impl_unittest.cc

diff --git a/remoting/host/token_validator_factory_impl_unittest.cc b/remoting/host/token_validator_factory_impl_unittest.cc

index fff915bf90edd0feb349190f9f292e9d8e2abdc7..fa30d8ff0a627a9fccd58401a3f3c4038f222d1c 100644

--- a/remoting/host/token_validator_factory_impl_unittest.cc

+++ b/remoting/host/token_validator_factory_impl_unittest.cc

@@ -93,7 +93,7 @@ TEST_F(TokenValidatorFactoryImplTest, Success) {

net::FakeURLFetcherFactory factory(NULL);

token_validator_ = token_validator_factory_->CreateTokenValidator(

kLocalJid, kRemoteJid);

- factory.SetFakeResponse(kTokenValidationUrl, CreateResponse(

+ factory.SetFakeResponse(GURL(kTokenValidationUrl), CreateResponse(

token_validator_->token_scope()), true);

token_validator_->ValidateThirdPartyToken(

kToken, base::Bind(&TokenValidatorFactoryImplTest::SuccessCallback,

@@ -105,7 +105,7 @@ TEST_F(TokenValidatorFactoryImplTest, BadToken) {

net::FakeURLFetcherFactory factory(NULL);

token_validator_ = token_validator_factory_->CreateTokenValidator(

kLocalJid, kRemoteJid);

- factory.SetFakeResponse(kTokenValidationUrl, std::string(), false);

+ factory.SetFakeResponse(GURL(kTokenValidationUrl), std::string(), false);

token_validator_->ValidateThirdPartyToken(

kToken, base::Bind(&TokenValidatorFactoryImplTest::FailureCallback,

base::Unretained(this)));

@@ -116,7 +116,8 @@ TEST_F(TokenValidatorFactoryImplTest, BadScope) {

net::FakeURLFetcherFactory factory(NULL);

token_validator_ = token_validator_factory_->CreateTokenValidator(

kLocalJid, kRemoteJid);

- factory.SetFakeResponse(kTokenValidationUrl, CreateResponse(kBadScope), true);

+ factory.SetFakeResponse(

+ GURL(kTokenValidationUrl), CreateResponse(kBadScope), true);

token_validator_->ValidateThirdPartyToken(

kToken, base::Bind(&TokenValidatorFactoryImplTest::FailureCallback,

base::Unretained(this)));

@@ -127,7 +128,7 @@ TEST_F(TokenValidatorFactoryImplTest, DeleteOnFailure) {

net::FakeURLFetcherFactory factory(NULL);

token_validator_ = token_validator_factory_->CreateTokenValidator(

kLocalJid, kRemoteJid);

- factory.SetFakeResponse(kTokenValidationUrl, std::string(), false);

+ factory.SetFakeResponse(GURL(kTokenValidationUrl), std::string(), false);

token_validator_->ValidateThirdPartyToken(

kToken, base::Bind(

&TokenValidatorFactoryImplTest::DeleteOnFailureCallback,

« no previous file with comments | « net/url_request/test_url_fetcher_factory.cc ('k') | no next file » | no next file with comments »