Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2574)

Unified Diff: chrome/browser/policy/preg_parser_win_unittest.cc

Issue 23704008: Properly handle zero-sized fields in the PReg parser. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/preg_parser_win_unittest.cc
diff --git a/chrome/browser/policy/preg_parser_win_unittest.cc b/chrome/browser/policy/preg_parser_win_unittest.cc
index 31ba4f0236903953adcb6489321a3341d82da7ee..3d219b5aec1b94be6a0a99959191a5a409881dd3 100644
--- a/chrome/browser/policy/preg_parser_win_unittest.cc
+++ b/chrome/browser/policy/preg_parser_win_unittest.cc
@@ -43,8 +43,9 @@ testing::AssertionResult RegistryDictEquals(const RegistryDict& a,
if (iter_value_a->first != iter_value_b->first ||
!base::Value::Equals(iter_value_a->second, iter_value_b->second)) {
return testing::AssertionFailure()
- << "Value mismatch " << iter_value_a->first
- << " vs. " << iter_value_b->first;
+ << "Value mismatch "
+ << iter_value_a->first << "=" << *iter_value_a->second
+ << " vs. " << iter_value_b->first << "=" << *iter_value_b->second;
}
}
@@ -108,6 +109,7 @@ TEST(PRegParserWinTest, TestParseFile) {
expected.SetKey("RestoreOnStartupURLs", startup_urls.Pass());
SetInteger(&expected, "ShowHomeButton", 1);
SetString(&expected, "Snowman", "\xE2\x98\x83");
+ SetString(&expected, "Empty", "");
EXPECT_TRUE(RegistryDictEquals(dict, expected));
}

Powered by Google App Engine
This is Rietveld 408576698