Linux build: Use sysroot when calculating dependencies

Linux build: Use sysroot when calculating dependencies

Additionally, this CL also bundles part of dpkg-shlibdeps.  The version of dpkg-shlibdeps was too old on Precise to support the feature we needed for using the sysroot to calculate dependencies (specifically, the "-l" option was needed).  This meant we needed to temporarily bundle a newer version dpkg-dev to get this working on Precise.

Trusty has a newer version of dpkg-dev with the necessary feature, so dpkg-dev should be removed once the builders are entirely switch off of Precise.

This can be done by reverting this CL and applying ps40001 from this CL.

BUG=564904
R=thestig@chromium.org,sbc@chromium.org,jochen@chromium.org

Committed: https://crrev.com/0db721ca35ac387f5adf6bb9d7ec5ec24be4ac6e
Committed: https://crrev.com/7a01af4fd7ef884b60600e2a87f567c4f1ca6700
Cr-Original-Commit-Position: refs/heads/master@{#425842}
Cr-Commit-Position: refs/heads/master@{#426047}

[Tom (Use chromium acct), 2016-10-12 19:33:06]

Description was changed from

==========
Linux build: Use sysroot when calculating dependencies

BUG=564904
==========

to

==========
Linux build: Use sysroot when calculating dependencies

BUG=564904
R=thestig@chromium.org,sbc@chromium.org
==========

[Tom (Use chromium acct), 2016-10-12 19:33:06]

thomasanderson@google.com changed reviewers:
+ sbc@chromium.org, thestig@chromium.org

[Tom (Use chromium acct), 2016-10-12 19:33:40]

Note that this PS depends on upgrading the sysroots, which I'll to rn

[Lei Zhang, 2016-10-12 19:36:40]

Is https://codereview.chromium.org/2389263007/ obsolete then?

[Tom (Use chromium acct), 2016-10-12 19:41:16]

On 2016/10/12 19:36:40, Lei Zhang wrote:
> Is https://codereview.chromium.org/2389263007/ obsolete then?

yes

[Sam Clegg, 2016-10-12 20:36:23]

On 2016/10/12 19:41:16, Tom Anderson wrote:
> On 2016/10/12 19:36:40, Lei Zhang wrote:
> > Is https://codereview.chromium.org/2389263007/ obsolete then?
> 
> yes

LGTM, assuming you've tested the package building locally.

[Lei Zhang, 2016-10-12 20:55:30]

lgtm

https://codereview.chromium.org/2411423002/diff/20001/chrome/installer/linux/...
File chrome/installer/linux/debian/build.sh (right):

https://codereview.chromium.org/2411423002/diff/20001/chrome/installer/linux/...
chrome/installer/linux/debian/build.sh:273: if [ ${TARGETARCH} == "x64" ]; then
single = again

[Tom (Use chromium acct), 2016-10-12 22:02:09]

Dah!  The version of dpkg-shlibdeps packaged with Precise doesn't have the -l
option ಠ_ಠ

I'll test using LD_LIBRARY_PATH as a workaround...

https://codereview.chromium.org/2411423002/diff/20001/chrome/installer/linux/...
File chrome/installer/linux/debian/build.sh (right):

https://codereview.chromium.org/2411423002/diff/20001/chrome/installer/linux/...
chrome/installer/linux/debian/build.sh:273: if [ ${TARGETARCH} == "x64" ]; then
On 2016/10/12 20:55:30, Lei Zhang wrote:
> single = again

Done.

[Tom (Use chromium acct), 2016-10-12 22:28:38]

On 2016/10/12 22:02:09, Tom Anderson wrote:
> Dah!  The version of dpkg-shlibdeps packaged with Precise doesn't have the -l
> option ಠ_ಠ
> 
> I'll test using LD_LIBRARY_PATH as a workaround...
> 

Unfortunately that doesn't work when cross-compiling.  From the doc:
"-ldirectory Add directory to the list of directories to search for private
shared libraries (since dpkg 1.17.0). This option can be used multiple times.
Note: Use this option instead of setting LD_LIBRARY_PATH, as that environment
variable is used to control the run-time linker and abusing it to set the shared
library paths at build-time  can be problematic when cross-compiling for
example."

The error I get is libc.so.6: version `GLIBC_2.14' not found (required by sed)

Lei, can we temporarily bundle dpkg-shlibdeps.pl from dpkg-dev until the bots
are switched over?  Or better yet, disable this stupid check during the switch?

[Lei Zhang, 2016-10-12 22:45:33]

On 2016/10/12 22:28:38, Tom Anderson wrote:
> Lei, can we temporarily bundle dpkg-shlibdeps.pl from dpkg-dev until the bots
> are switched over?  Or better yet, disable this stupid check during the
switch?

Where do we bundle it exactly? Just somewhere in the tree so it ends up in the
PATH?

[Tom (Use chromium acct), 2016-10-12 22:51:38]

On 2016/10/12 22:45:33, Lei Zhang wrote:
> On 2016/10/12 22:28:38, Tom Anderson wrote:
> > Lei, can we temporarily bundle dpkg-shlibdeps.pl from dpkg-dev until the
bots
> > are switched over?  Or better yet, disable this stupid check during the
> switch?
> 
> Where do we bundle it exactly? Just somewhere in the tree so it ends up in the
> PATH?

Can we put it in //src/chrome/installer/linux/debian/dpkg-dev/scripts?
There are some more perl files that dpkg-shlibdeps pulls in...

[Lei Zhang, 2016-10-12 22:58:37]

On 2016/10/12 22:51:38, Tom Anderson wrote:
> On 2016/10/12 22:45:33, Lei Zhang wrote:
> > On 2016/10/12 22:28:38, Tom Anderson wrote:
> > > Lei, can we temporarily bundle dpkg-shlibdeps.pl from dpkg-dev until the
> bots
> > > are switched over?  Or better yet, disable this stupid check during the
> > switch?
> > 
> > Where do we bundle it exactly? Just somewhere in the tree so it ends up in
the
> > PATH?
> 
> Can we put it in //src/chrome/installer/linux/debian/dpkg-dev/scripts?
> There are some more perl files that dpkg-shlibdeps pulls in...

Sure... since this is all temporary until we finish the transition.

[Sam Clegg, 2016-10-12 23:27:46]

On 2016/10/12 22:58:37, Lei Zhang wrote:
> On 2016/10/12 22:51:38, Tom Anderson wrote:
> > On 2016/10/12 22:45:33, Lei Zhang wrote:
> > > On 2016/10/12 22:28:38, Tom Anderson wrote:
> > > > Lei, can we temporarily bundle dpkg-shlibdeps.pl from dpkg-dev until the
> > bots
> > > > are switched over?  Or better yet, disable this stupid check during the
> > > switch?
> > > 
> > > Where do we bundle it exactly? Just somewhere in the tree so it ends up in
> the
> > > PATH?
> > 
> > Can we put it in //src/chrome/installer/linux/debian/dpkg-dev/scripts?
> > There are some more perl files that dpkg-shlibdeps pulls in...
> 
> Sure... since this is all temporary until we finish the transition.

Or we could just delay this change until the transition is done?  The transition
is no longer blocked on this change, right?

[Tom (Use chromium acct), 2016-10-12 23:29:48]

On 2016/10/12 23:27:46, Sam Clegg wrote:
> On 2016/10/12 22:58:37, Lei Zhang wrote:
> > On 2016/10/12 22:51:38, Tom Anderson wrote:
> > > On 2016/10/12 22:45:33, Lei Zhang wrote:
> > > > On 2016/10/12 22:28:38, Tom Anderson wrote:
> > > > > Lei, can we temporarily bundle dpkg-shlibdeps.pl from dpkg-dev until
the
> > > bots
> > > > > are switched over?  Or better yet, disable this stupid check during
the
> > > > switch?
> > > > 
> > > > Where do we bundle it exactly? Just somewhere in the tree so it ends up
in
> > the
> > > > PATH?
> > > 
> > > Can we put it in //src/chrome/installer/linux/debian/dpkg-dev/scripts?
> > > There are some more perl files that dpkg-shlibdeps pulls in...
> > 
> > Sure... since this is all temporary until we finish the transition.
> 
> Or we could just delay this change until the transition is done?  The
transition
> is no longer blocked on this change, right?

It is, unfortunately.  The expected_deps_trusty thing didn't fix it, because the
calculated dependencies may be different, even among different trusty installs. 
See https://bugs.chromium.org/p/chromium/issues/detail?id=564904#c39

[Tom (Use chromium acct), 2016-10-12 23:32:31]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2016-10-12 23:32:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, sbc@chromium.org
Link to the patchset: https://codereview.chromium.org/2411423002/#ps40001
(title: "== -> =")

[commit-bot: I haz the power, 2016-10-12 23:33:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom (Use chromium acct), 2016-10-12 23:40:26]

The CQ bit was unchecked by thomasanderson@google.com

[Tom (Use chromium acct), 2016-10-12 23:42:13]

sorry, meant to tick the box on a different CL.  Unchecked

[Tom (Use chromium acct), 2016-10-13 02:04:05]

Description was changed from

==========
Linux build: Use sysroot when calculating dependencies

BUG=564904
R=thestig@chromium.org,sbc@chromium.org
==========

to

==========
Linux build: Use sysroot when calculating dependencies

BUG=564904
R=thestig@chromium.org,sbc@chromium.org,jochen@chromium.org
==========

[Tom (Use chromium acct), 2016-10-13 02:05:26]

thomasanderson@google.com changed reviewers:
+ jochen@chromium.org

[Tom (Use chromium acct), 2016-10-13 02:05:27]

+jochen@ for //third_party

[Tom (Use chromium acct), 2016-10-13 18:24:23]

Lei I needed 2 users in the OWNERS file, so I added you.  Is that ok?

[Lei Zhang, 2016-10-13 18:27:48]

On 2016/10/13 18:24:23, Tom Anderson wrote:
> Lei I needed 2 users in the OWNERS file, so I added you.  Is that ok?

Sure. Add sbc@ as well?

[Lei Zhang, 2016-10-13 18:28:55]

https://codereview.chromium.org/2411423002/diff/80001/third_party/dpkg-dev/RE...
File third_party/dpkg-dev/README.chromium (right):

https://codereview.chromium.org/2411423002/diff/80001/third_party/dpkg-dev/RE...
third_party/dpkg-dev/README.chromium:4: License: GPLv2
BTW, I see many third_party/*/README.chromium files have:

License File: NOT_SHIPPED

[Sam Clegg, 2016-10-13 18:34:29]

On 2016/10/13 18:28:55, Lei Zhang wrote:
>
https://codereview.chromium.org/2411423002/diff/80001/third_party/dpkg-dev/RE...
> File third_party/dpkg-dev/README.chromium (right):
> 
>
https://codereview.chromium.org/2411423002/diff/80001/third_party/dpkg-dev/RE...
> third_party/dpkg-dev/README.chromium:4: License: GPLv2
> BTW, I see many third_party/*/README.chromium files have:
> 
> License File: NOT_SHIPPED

This seems like a very heavy handed approach.  I wish there was a way to avoid
checking in all this GPL code into third_party.   IIUC this is only needed until
we can get the release builders upgraded to trusty?   If this is true, then I'd
like to see a bug opened to remove this code from third_party as soon as the
bots are updated, and the referenced in README.chromium.

[Tom (Use chromium acct), 2016-10-13 18:59:52]

On 2016/10/13 18:27:48, Lei Zhang wrote:
> On 2016/10/13 18:24:23, Tom Anderson wrote:
> > Lei I needed 2 users in the OWNERS file, so I added you.  Is that ok?
> 
> Sure. Add sbc@ as well?

Done.

On 2016/10/13 18:28:55, Lei Zhang wrote:
>
https://codereview.chromium.org/2411423002/diff/80001/third_party/dpkg-dev/RE...
> File third_party/dpkg-dev/README.chromium (right):
> 
>
https://codereview.chromium.org/2411423002/diff/80001/third_party/dpkg-dev/RE...
> third_party/dpkg-dev/README.chromium:4: License: GPLv2
> BTW, I see many third_party/*/README.chromium files have:
> 
> License File: NOT_SHIPPED

Added.  Makes sense since nothing is actually getting compiled into the bina

On 2016/10/13 18:34:29, Sam Clegg wrote:
> This seems like a very heavy handed approach.  I wish there was a way to avoid
> checking in all this GPL code into third_party.   IIUC this is only needed
until
> we can get the release builders upgraded to trusty?

That's right

> If this is true, then I'd
> like to see a bug opened to remove this code from third_party as soon as the
> bots are updated, and the referenced in README.chromium.

Done & added bug 655755

[Tom (Use chromium acct), 2016-10-13 22:33:19]

thomasanderson@google.com changed reviewers:
+ dpranke@chromium.org

[Tom (Use chromium acct), 2016-10-13 22:33:20]

+dpranke

[Dirk Pranke, 2016-10-13 23:21:21]

dpranke@chromium.org changed reviewers:
+ brettw@chromium.org, open-source-third-party-reviews@google.com,
security@chromium.org
- jochen@chromium.org

[Dirk Pranke, 2016-10-13 23:21:22]

Please update the CL description to include some description of why we're
checking in the dpkg code and when we'll be able to remove it (I know you have
that in the README.chromium file, but it'd be good to summarize it here, too).

[Tom (Use chromium acct), 2016-10-13 23:27:22]

Description was changed from

==========
Linux build: Use sysroot when calculating dependencies

BUG=564904
R=thestig@chromium.org,sbc@chromium.org,jochen@chromium.org
==========

to

==========
Linux build: Use sysroot when calculating dependencies

Additionally, this CL also bundles part of dpkg-shlibdeps.  The version of
dpkg-shlibdeps was too old on Precise to support the feature we needed for using
the sysroot to calculate dependencies (specifically, the "-l" option was
needed).  This meant we needed to temporarily bundle a newer version dpkg-dev to
get this working on Precise.

Trusty has a newer version of dpkg-dev with the necessary feature, so dpkg-dev
should be removed once the builders are entirely switch off of Precise.

This can be done by reverting this CL and applying ps40001 from this CL.

BUG=564904
R=thestig@chromium.org,sbc@chromium.org,jochen@chromium.org
==========

[Tom (Use chromium acct), 2016-10-13 23:29:42]

On 2016/10/13 23:21:22, Dirk Pranke wrote:
> Please update the CL description to include some description of why we're
> checking in the dpkg code and when we'll be able to remove it (I know you have
> that in the README.chromium file, but it'd be good to summarize it here, too).

Done.

The latest PS ignores dpkg-dev in checklicenses.py

[Dirk Pranke, 2016-10-13 23:31:08]

On 2016/10/13 23:29:42, Tom Anderson wrote:
> On 2016/10/13 23:21:22, Dirk Pranke wrote:
> > Please update the CL description to include some description of why we're
> > checking in the dpkg code and when we'll be able to remove it (I know you
have
> > that in the README.chromium file, but it'd be good to summarize it here,
too).
> 
> Done.
> 
> The latest PS ignores dpkg-dev in checklicenses.py

lgtm once we have approvals from open-source-third-party-reviews@ and security@.

[Martin Barbella, 2016-10-14 17:44:04]

On 2016/10/13 23:31:08, Dirk Pranke wrote:
> On 2016/10/13 23:29:42, Tom Anderson wrote:
> > On 2016/10/13 23:21:22, Dirk Pranke wrote:
> > > Please update the CL description to include some description of why we're
> > > checking in the dpkg code and when we'll be able to remove it (I know you
> have
> > > that in the README.chromium file, but it'd be good to summarize it here,
> too).
> > 
> > Done.
> > 
> > The latest PS ignores dpkg-dev in checklicenses.py
> 
> lgtm once we have approvals from open-source-third-party-reviews@ and
security@.

third_party LGTM from security

[xam, 2016-10-17 22:53:00]

On 2016/10/14 17:44:04, Martin Barbella wrote:
> On 2016/10/13 23:31:08, Dirk Pranke wrote:
> > On 2016/10/13 23:29:42, Tom Anderson wrote:
> > > On 2016/10/13 23:21:22, Dirk Pranke wrote:
> > > > Please update the CL description to include some description of why
we're
> > > > checking in the dpkg code and when we'll be able to remove it (I know
you
> > have
> > > > that in the README.chromium file, but it'd be good to summarize it here,
> > too).
> > > 
> > > Done.
> > > 
> > > The latest PS ignores dpkg-dev in checklicenses.py
> > 
> > lgtm once we have approvals from open-source-third-party-reviews@ and
> security@.
> 
> third_party LGTM from security

LGTM from OSPTR

[Tom (Use chromium acct), 2016-10-17 23:24:57]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2016-10-17 23:24:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, sbc@chromium.org
Link to the patchset: https://codereview.chromium.org/2411423002/#ps120001
(title: "Ignore dpkg-dev in checklicenses.py")

[commit-bot: I haz the power, 2016-10-17 23:25:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-10-17 23:28:30]

https://codereview.chromium.org/2411423002/diff/120001/tools/checklicenses/ch...
File tools/checklicenses/checklicenses.py (right):

https://codereview.chromium.org/2411423002/diff/120001/tools/checklicenses/ch...
tools/checklicenses/checklicenses.py:237: 'third_party/dpkg-dev': [
I'm lgtm-ing this separately.

No need to stop the CQ, but it would be nice to add a bug number here so readers
can easily understand why this is here, and so you'll remember to remove it in
the near future.

https://codereview.chromium.org/2411423002/diff/120001/tools/checklicenses/ch...
tools/checklicenses/checklicenses.py:240:
'third_party/catapult/firefighter/default/tracing/third_party/devscripts': [
Also, the 3 devscripts entries are grouped together. It would've been nice to
put it in a separate block.

[commit-bot: I haz the power, 2016-10-18 01:05:56]

Description was changed from

==========
Linux build: Use sysroot when calculating dependencies

Additionally, this CL also bundles part of dpkg-shlibdeps.  The version of
dpkg-shlibdeps was too old on Precise to support the feature we needed for using
the sysroot to calculate dependencies (specifically, the "-l" option was
needed).  This meant we needed to temporarily bundle a newer version dpkg-dev to
get this working on Precise.

Trusty has a newer version of dpkg-dev with the necessary feature, so dpkg-dev
should be removed once the builders are entirely switch off of Precise.

This can be done by reverting this CL and applying ps40001 from this CL.

BUG=564904
R=thestig@chromium.org,sbc@chromium.org,jochen@chromium.org
==========

to

==========
Linux build: Use sysroot when calculating dependencies

Additionally, this CL also bundles part of dpkg-shlibdeps.  The version of
dpkg-shlibdeps was too old on Precise to support the feature we needed for using
the sysroot to calculate dependencies (specifically, the "-l" option was
needed).  This meant we needed to temporarily bundle a newer version dpkg-dev to
get this working on Precise.

Trusty has a newer version of dpkg-dev with the necessary feature, so dpkg-dev
should be removed once the builders are entirely switch off of Precise.

This can be done by reverting this CL and applying ps40001 from this CL.

BUG=564904
R=thestig@chromium.org,sbc@chromium.org,jochen@chromium.org
==========

[commit-bot: I haz the power, 2016-10-18 01:05:59]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-10-18 01:08:05]

Description was changed from

==========
Linux build: Use sysroot when calculating dependencies

Additionally, this CL also bundles part of dpkg-shlibdeps.  The version of
dpkg-shlibdeps was too old on Precise to support the feature we needed for using
the sysroot to calculate dependencies (specifically, the "-l" option was
needed).  This meant we needed to temporarily bundle a newer version dpkg-dev to
get this working on Precise.

Trusty has a newer version of dpkg-dev with the necessary feature, so dpkg-dev
should be removed once the builders are entirely switch off of Precise.

This can be done by reverting this CL and applying ps40001 from this CL.

BUG=564904
R=thestig@chromium.org,sbc@chromium.org,jochen@chromium.org
==========

to

==========
Linux build: Use sysroot when calculating dependencies

Additionally, this CL also bundles part of dpkg-shlibdeps.  The version of
dpkg-shlibdeps was too old on Precise to support the feature we needed for using
the sysroot to calculate dependencies (specifically, the "-l" option was
needed).  This meant we needed to temporarily bundle a newer version dpkg-dev to
get this working on Precise.

Trusty has a newer version of dpkg-dev with the necessary feature, so dpkg-dev
should be removed once the builders are entirely switch off of Precise.

This can be done by reverting this CL and applying ps40001 from this CL.

BUG=564904
R=thestig@chromium.org,sbc@chromium.org,jochen@chromium.org

Committed: https://crrev.com/0db721ca35ac387f5adf6bb9d7ec5ec24be4ac6e
Cr-Commit-Position: refs/heads/master@{#425842}
==========

[commit-bot: I haz the power, 2016-10-18 01:08:07]

Patchset 7 (id:??) landed as
https://crrev.com/0db721ca35ac387f5adf6bb9d7ec5ec24be4ac6e
Cr-Commit-Position: refs/heads/master@{#425842}

[Tom (Use chromium acct), 2016-10-18 04:06:20]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2425693003/ by thomasanderson@google.com.

The reason for reverting is: libdbus dependency issue
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%...

dpkg-shlibdeps.pl: warning: binaries to analyze should already be installed in
their package's directory
---
/b/c/b/Google_Chrome_Linux_x64/src/out/Release/installer/debian/expected_deps_x64_wheezy	2016-10-17
19:19:19.864623702 -0700
+++ actual	2016-10-17 20:14:30.636925109 -0700
@@ -4,7 +4,7 @@
 libc6 (>= 2.11)
 libcairo2 (>= 1.6.0)
 libcups2 (>= 1.4.0)
-libdbus-1-3 (>= 1.2.14)
+libdbus-1-3 (>= 1.1.4)
 libexpat1 (>= 2.0.1)
 libfontconfig1 (>= 2.9.0)
 libfreetype6 (>= 2.3.9).

[Tom Anderson, 2016-10-18 04:12:32]

Description was changed from

==========
Linux build: Use sysroot when calculating dependencies

Additionally, this CL also bundles part of dpkg-shlibdeps.  The version of
dpkg-shlibdeps was too old on Precise to support the feature we needed for using
the sysroot to calculate dependencies (specifically, the "-l" option was
needed).  This meant we needed to temporarily bundle a newer version dpkg-dev to
get this working on Precise.

Trusty has a newer version of dpkg-dev with the necessary feature, so dpkg-dev
should be removed once the builders are entirely switch off of Precise.

This can be done by reverting this CL and applying ps40001 from this CL.

BUG=564904
R=thestig@chromium.org,sbc@chromium.org,jochen@chromium.org

Committed: https://crrev.com/0db721ca35ac387f5adf6bb9d7ec5ec24be4ac6e
Cr-Commit-Position: refs/heads/master@{#425842}
==========

to

==========
Linux build: Use sysroot when calculating dependencies

Additionally, this CL also bundles part of dpkg-shlibdeps.  The version of
dpkg-shlibdeps was too old on Precise to support the feature we needed for using
the sysroot to calculate dependencies (specifically, the "-l" option was
needed).  This meant we needed to temporarily bundle a newer version dpkg-dev to
get this working on Precise.

Trusty has a newer version of dpkg-dev with the necessary feature, so dpkg-dev
should be removed once the builders are entirely switch off of Precise.

This can be done by reverting this CL and applying ps40001 from this CL.

BUG=564904
R=thestig@chromium.org,sbc@chromium.org,jochen@chromium.org

Committed: https://crrev.com/0db721ca35ac387f5adf6bb9d7ec5ec24be4ac6e
Cr-Commit-Position: refs/heads/master@{#425842}
==========

[Tom (Use chromium acct), 2016-10-18 04:47:31]

Patchset #8 (id:140001) has been deleted

[Tom (Use chromium acct), 2016-10-18 04:50:40]

Patchset #8 (id:160001) has been deleted

[Tom (Use chromium acct), 2016-10-18 18:10:39]

Just a small update.  After some debugging, I found the dependency difference
was due to me using allow_posix_link_time_opt=false in my args.gn. (maybe we
should add a warning for this in the future?)
I'll land a new patch set later today after chrome finishes linking using the
jessie sysroot.

[Tom (Use chromium acct), 2016-10-18 19:24:56]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2016-10-18 19:25:02]

The patchset sent to the CQ was uploaded after l-g-t-m from sbc@chromium.org,
xam@google.com, dpranke@chromium.org, thestig@chromium.org,
mbarbella@chromium.org
Link to the patchset:
https://chromiumcodereview-hr.appspot.com/2411423002/#ps180001 (title: "Add
comment")

[Tom (Use chromium acct), 2016-10-18 19:25:15]

https://chromiumcodereview-hr.appspot.com/2411423002/diff/120001/tools/checkl...
File tools/checklicenses/checklicenses.py (right):

https://chromiumcodereview-hr.appspot.com/2411423002/diff/120001/tools/checkl...
tools/checklicenses/checklicenses.py:237: 'third_party/dpkg-dev': [
On 2016/10/17 23:28:30, Lei Zhang wrote:
> I'm lgtm-ing this separately.
> 
> No need to stop the CQ, but it would be nice to add a bug number here so
readers
> can easily understand why this is here, and so you'll remember to remove it in
> the near future.

Done.

https://chromiumcodereview-hr.appspot.com/2411423002/diff/120001/tools/checkl...
tools/checklicenses/checklicenses.py:240:
'third_party/catapult/firefighter/default/tracing/third_party/devscripts': [
On 2016/10/17 23:28:30, Lei Zhang wrote:
> Also, the 3 devscripts entries are grouped together. It would've been nice to
> put it in a separate block.

Done.

[commit-bot: I haz the power, 2016-10-18 19:25:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 20:51:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 20:51:54]

Exceeded global retry quota

[Tom (Use chromium acct), 2016-10-18 21:07:48]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2016-10-18 21:08:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 21:23:10]

Description was changed from

==========
Linux build: Use sysroot when calculating dependencies

Additionally, this CL also bundles part of dpkg-shlibdeps.  The version of
dpkg-shlibdeps was too old on Precise to support the feature we needed for using
the sysroot to calculate dependencies (specifically, the "-l" option was
needed).  This meant we needed to temporarily bundle a newer version dpkg-dev to
get this working on Precise.

Trusty has a newer version of dpkg-dev with the necessary feature, so dpkg-dev
should be removed once the builders are entirely switch off of Precise.

This can be done by reverting this CL and applying ps40001 from this CL.

BUG=564904
R=thestig@chromium.org,sbc@chromium.org,jochen@chromium.org

Committed: https://crrev.com/0db721ca35ac387f5adf6bb9d7ec5ec24be4ac6e
Cr-Commit-Position: refs/heads/master@{#425842}
==========

to

==========
Linux build: Use sysroot when calculating dependencies

Additionally, this CL also bundles part of dpkg-shlibdeps.  The version of
dpkg-shlibdeps was too old on Precise to support the feature we needed for using
the sysroot to calculate dependencies (specifically, the "-l" option was
needed).  This meant we needed to temporarily bundle a newer version dpkg-dev to
get this working on Precise.

Trusty has a newer version of dpkg-dev with the necessary feature, so dpkg-dev
should be removed once the builders are entirely switch off of Precise.

This can be done by reverting this CL and applying ps40001 from this CL.

BUG=564904
R=thestig@chromium.org,sbc@chromium.org,jochen@chromium.org

Committed: https://crrev.com/0db721ca35ac387f5adf6bb9d7ec5ec24be4ac6e
Cr-Commit-Position: refs/heads/master@{#425842}
==========

[commit-bot: I haz the power, 2016-10-18 21:23:12]

Committed patchset #8 (id:180001)

[commit-bot: I haz the power, 2016-10-21 13:03:06]

Description was changed from

==========
Linux build: Use sysroot when calculating dependencies

Additionally, this CL also bundles part of dpkg-shlibdeps.  The version of
dpkg-shlibdeps was too old on Precise to support the feature we needed for using
the sysroot to calculate dependencies (specifically, the "-l" option was
needed).  This meant we needed to temporarily bundle a newer version dpkg-dev to
get this working on Precise.

Trusty has a newer version of dpkg-dev with the necessary feature, so dpkg-dev
should be removed once the builders are entirely switch off of Precise.

This can be done by reverting this CL and applying ps40001 from this CL.

BUG=564904
R=thestig@chromium.org,sbc@chromium.org,jochen@chromium.org

Committed: https://crrev.com/0db721ca35ac387f5adf6bb9d7ec5ec24be4ac6e
Cr-Commit-Position: refs/heads/master@{#425842}
==========

to

==========
Linux build: Use sysroot when calculating dependencies

Additionally, this CL also bundles part of dpkg-shlibdeps.  The version of
dpkg-shlibdeps was too old on Precise to support the feature we needed for using
the sysroot to calculate dependencies (specifically, the "-l" option was
needed).  This meant we needed to temporarily bundle a newer version dpkg-dev to
get this working on Precise.

Trusty has a newer version of dpkg-dev with the necessary feature, so dpkg-dev
should be removed once the builders are entirely switch off of Precise.

This can be done by reverting this CL and applying ps40001 from this CL.

BUG=564904
R=thestig@chromium.org,sbc@chromium.org,jochen@chromium.org

Committed: https://crrev.com/0db721ca35ac387f5adf6bb9d7ec5ec24be4ac6e
Committed: https://crrev.com/7a01af4fd7ef884b60600e2a87f567c4f1ca6700
Cr-Original-Commit-Position: refs/heads/master@{#425842}
Cr-Commit-Position: refs/heads/master@{#426047}
==========

[commit-bot: I haz the power, 2016-10-21 13:03:08]

Patchset 8 (id:??) landed as
https://crrev.com/7a01af4fd7ef884b60600e2a87f567c4f1ca6700
Cr-Commit-Position: refs/heads/master@{#426047}