git_cl: Allow server overriding.

git_cl: Allow server overriding.

BUG=chromium:657064
TEST=local
  - Ran "git cl status" during outage with override, works.

R=tandrii@chromium.org

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/a8fb3a2892ae47c87a2562743b0e7a6fd1c7cf6d

[dnj, 2016-10-18 18:16:33]

dnj@chromium.org changed reviewers:
+ agable@chromium.org, dnj@chromium.org

[dnj, 2016-10-18 18:16:33]

PTAL. If this lands, we can advise users to use this to upload and interact with
Rietveld during the outage.

[tandrii(chromium), 2016-10-18 18:24:20]

tandrii@chromium.org changed reviewers:
+ tandrii@chromium.org

[tandrii(chromium), 2016-10-18 18:24:21]

this will not work as intended for git cl try and git cl try-results, because
once you run git cl upload, codereview server is stored as property of the git
branch. Still, IMO given current state, this is a good trade off.

So, LGTM if you promise to revert this after outage ends.

[dnj, 2016-10-18 18:25:11]

On 2016/10/18 18:24:21, tandrii(chromium) wrote:
> this will not work as intended for git cl try and git cl try-results, because
> once you run git cl upload, codereview server is stored as property of the git
> branch. Still, IMO given current state, this is a good trade off.
> 
> So, LGTM if you promise to revert this after outage ends.

SGTM

[dnj (Google), 2016-10-18 18:25:33]

Description was changed from

==========
git_cl: Allow server overriding.

BUG=chromium:657064
TEST=local
  - Ran "git cl status" during outage with override, works.
==========

to

==========
git_cl: Allow server overriding.

BUG=chromium:657064
TEST=local
  - Ran "git cl status" during outage with override, works.

R=tandrii@chromium.org

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/a8fb3a2892ae47...
==========

[dnj (Google), 2016-10-18 18:25:35]

Committed patchset #1 (id:1) manually as
a8fb3a2892ae47c87a2562743b0e7a6fd1c7cf6d.

[agable, 2016-10-18 18:27:35]

I know everything is broken, but emergency pushes to depot_tools are dangerous
anyway.

Similar to tandrii, I'd like to have this be reverted as soon as the outage is
over, but this is also changing the public API of git-cl, which is
hard/annoying/unkind to simply revert.

I'm not sure that this workaround is really worthwhile, in that sense. But if
you (and tandrii) believe that it is, definitely go ahead and land it, and
prepare the revert CL.