Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 2643523002: Implement generic function type syntax in the VM (fixes #27966). (Closed)

Created:
3 years, 11 months ago by regis
Modified:
3 years, 4 months ago
Reviewers:
hausner, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement generic function type syntax in the VM (fixes #27966). The new function type syntax is allowed everywhere and not just in typedef. R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/97f968de1c54db99b5f567d3fd6379756e2416f7

Patch Set 1 #

Patch Set 2 : work in progress #

Total comments: 8

Patch Set 3 : address comment #

Patch Set 4 : refactor parsing of formal parameter per review request #

Unified diffs Side-by-side diffs Delta from patch set Stats (+602 lines, -213 lines) Patch
M runtime/vm/class_finalizer.h View 2 chunks +3 lines, -1 line 0 comments Download
M runtime/vm/class_finalizer.cc View 1 2 3 2 chunks +11 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 2 3 11 chunks +38 lines, -10 lines 0 comments Download
M runtime/vm/parser.h View 1 2 3 6 chunks +17 lines, -6 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 3 72 chunks +531 lines, -195 lines 0 comments Download
M runtime/vm/symbols.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language.status View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
regis
3 years, 11 months ago (2017-01-17 22:18:43 UTC) #2
hausner
LGTM. Sadly, this language change makes the parser quite a bit more difficult to understand. ...
3 years, 11 months ago (2017-01-18 18:54:53 UTC) #3
regis
Thanks! Since we were asked to hold onto this change until 1.23, I will have ...
3 years, 11 months ago (2017-01-18 20:24:24 UTC) #4
regis
3 years, 10 months ago (2017-01-27 16:45:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
97f968de1c54db99b5f567d3fd6379756e2416f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698