Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Unified Diff: third_party/WebKit/Source/modules/webauth/WebAuthentication.h

Issue 2788823002: Add the Mojo implementation of authenticator.mojom's MakeCredential. (Closed)
Patch Set: Addressing mkwst comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webauth/WebAuthentication.h
diff --git a/third_party/WebKit/Source/modules/webauth/WebAuthentication.h b/third_party/WebKit/Source/modules/webauth/WebAuthentication.h
index 262bc8b8c53479c13975471ce8f653873244035f..92ce08b60fcf93c08897d0afb54cc4dc6e272881 100644
--- a/third_party/WebKit/Source/modules/webauth/WebAuthentication.h
+++ b/third_party/WebKit/Source/modules/webauth/WebAuthentication.h
@@ -38,8 +38,6 @@ class WebAuthentication final
virtual ~WebAuthentication();
- void Dispose();
-
// WebAuthentication.idl
ScriptPromise makeCredential(ScriptState*,
const RelyingPartyAccount&,
@@ -50,24 +48,26 @@ class WebAuthentication final
const BufferSource&,
const AuthenticationAssertionOptions&);
- // ContextLifecycleObserver overrides.
- void ContextDestroyed(ExecutionContext*) override;
-
webauth::mojom::blink::Authenticator* Authenticator() const {
return authenticator_.get();
}
- void OnMakeCredential(ScriptPromiseResolver*,
- Vector<webauth::mojom::blink::ScopedCredentialInfoPtr>);
- bool MarkRequestComplete(ScriptPromiseResolver*);
-
- void OnAuthenticatorConnectionError();
+ // ContextLifecycleObserver overrides.
+ void ContextDestroyed(ExecutionContext*) override;
DECLARE_VIRTUAL_TRACE();
private:
explicit WebAuthentication(LocalFrame&);
+ void OnMakeCredential(ScriptPromiseResolver*,
+ webauth::mojom::blink::AuthenticatorStatus,
+ webauth::mojom::blink::ScopedCredentialInfoPtr);
+ ScriptPromise RejectIfNotSupported(ScriptState*);
+ void OnAuthenticatorConnectionError();
+ bool MarkRequestComplete(ScriptPromiseResolver*);
+ void Cleanup();
+
webauth::mojom::blink::AuthenticatorPtr authenticator_;
HeapHashSet<Member<ScriptPromiseResolver>> authenticator_requests_;
};
« no previous file with comments | « third_party/WebKit/Source/modules/webauth/OWNERS ('k') | third_party/WebKit/Source/modules/webauth/WebAuthentication.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698