Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Side by Side Diff: ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios.mm

Issue 2868983003: Ensure History > Recent Tabs restore preserves window disposition. (Closed)
Patch Set: Remove NOTREACHED(). Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios.h" 5 #include "ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 sessions::LiveTab* TabRestoreServiceDelegateImplIOS::GetLiveTabAt( 61 sessions::LiveTab* TabRestoreServiceDelegateImplIOS::GetLiveTabAt(
62 int index) const { 62 int index) const {
63 return nullptr; 63 return nullptr;
64 } 64 }
65 65
66 sessions::LiveTab* TabRestoreServiceDelegateImplIOS::GetActiveLiveTab() const { 66 sessions::LiveTab* TabRestoreServiceDelegateImplIOS::GetActiveLiveTab() const {
67 return nullptr; 67 return nullptr;
68 } 68 }
69 69
70 bool TabRestoreServiceDelegateImplIOS::IsTabPinned(int index) const { 70 bool TabRestoreServiceDelegateImplIOS::IsTabPinned(int index) const {
71 // Not supported by iOS.
71 return false; 72 return false;
72 } 73 }
73 74
75 const gfx::Rect TabRestoreServiceDelegateImplIOS::GetRestoredBounds() const {
76 // Not supported by iOS.
77 return gfx::Rect();
78 }
79
80 ui::WindowShowState TabRestoreServiceDelegateImplIOS::GetRestoredState() const {
81 // Not supported by iOS.
82 return ui::SHOW_STATE_NORMAL;
83 }
84
85 std::string TabRestoreServiceDelegateImplIOS::GetWorkspace() const {
86 // Not supported by iOS.
87 return std::string();
88 }
89
74 sessions::LiveTab* TabRestoreServiceDelegateImplIOS::AddRestoredTab( 90 sessions::LiveTab* TabRestoreServiceDelegateImplIOS::AddRestoredTab(
75 const std::vector<sessions::SerializedNavigationEntry>& navigations, 91 const std::vector<sessions::SerializedNavigationEntry>& navigations,
76 int tab_index, 92 int tab_index,
77 int selected_navigation, 93 int selected_navigation,
78 const std::string& extension_app_id, 94 const std::string& extension_app_id,
79 bool select, 95 bool select,
80 bool pin, 96 bool pin,
81 bool from_last_session, 97 bool from_last_session,
82 const sessions::PlatformSpecificTabData* tab_platform_data, 98 const sessions::PlatformSpecificTabData* tab_platform_data,
83 const std::string& user_agent_override) { 99 const std::string& user_agent_override) {
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 Tab* tab = tab_model().currentTab; 131 Tab* tab = tab_model().currentTab;
116 [tab replaceHistoryWithNavigations:navigations 132 [tab replaceHistoryWithNavigations:navigations
117 currentIndex:selected_navigation]; 133 currentIndex:selected_navigation];
118 return nullptr; 134 return nullptr;
119 } 135 }
120 136
121 void TabRestoreServiceDelegateImplIOS::CloseTab() { 137 void TabRestoreServiceDelegateImplIOS::CloseTab() {
122 WebStateList* web_state_list = [tab_model() webStateList]; 138 WebStateList* web_state_list = [tab_model() webStateList];
123 web_state_list->CloseWebStateAt(web_state_list->active_index()); 139 web_state_list->CloseWebStateAt(web_state_list->active_index());
124 } 140 }
OLDNEW
« no previous file with comments | « ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698