Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Side by Side Diff: content/browser/download/save_file.cc

Issue 2890853002: Downloads: replace BrowserThread::FILE with task scheduler. (Closed)
Patch Set: Address Avi's comments. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/download/save_file.h ('k') | content/browser/download/save_file_manager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/download/save_file.h" 5 #include "content/browser/download/save_file.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "content/public/browser/browser_thread.h" 8 #include "content/browser/download/download_task_runner.h"
9 #include "net/log/net_log_with_source.h" 9 #include "net/log/net_log_with_source.h"
10 10
11 namespace content { 11 namespace content {
12 12
13 // TODO(asanka): SaveFile should use the target directory of the save package as 13 // TODO(asanka): SaveFile should use the target directory of the save package as
14 // the default download directory when initializing |file_|. 14 // the default download directory when initializing |file_|.
15 // Unfortunately, as it is, constructors of SaveFile don't always 15 // Unfortunately, as it is, constructors of SaveFile don't always
16 // have access to the SavePackage at this point. 16 // have access to the SavePackage at this point.
17 SaveFile::SaveFile(const SaveFileCreateInfo* info, bool calculate_hash) 17 SaveFile::SaveFile(const SaveFileCreateInfo* info, bool calculate_hash)
18 : file_(net::NetLogWithSource()), info_(info) { 18 : file_(net::NetLogWithSource()), info_(info) {
19 DCHECK_CURRENTLY_ON(BrowserThread::FILE); 19 DCHECK(GetDownloadTaskRunner()->RunsTasksInCurrentSequence());
20 20
21 DCHECK(info); 21 DCHECK(info);
22 DCHECK(info->path.empty()); 22 DCHECK(info->path.empty());
23 } 23 }
24 24
25 SaveFile::~SaveFile() { 25 SaveFile::~SaveFile() {
26 DCHECK_CURRENTLY_ON(BrowserThread::FILE); 26 DCHECK(GetDownloadTaskRunner()->RunsTasksInCurrentSequence());
27 } 27 }
28 28
29 DownloadInterruptReason SaveFile::Initialize() { 29 DownloadInterruptReason SaveFile::Initialize() {
30 return file_.Initialize(base::FilePath(), base::FilePath(), base::File(), 0, 30 return file_.Initialize(base::FilePath(), base::FilePath(), base::File(), 0,
31 std::string(), std::unique_ptr<crypto::SecureHash>(), 31 std::string(), std::unique_ptr<crypto::SecureHash>(),
32 false); 32 false);
33 } 33 }
34 34
35 DownloadInterruptReason SaveFile::AppendDataToFile(const char* data, 35 DownloadInterruptReason SaveFile::AppendDataToFile(const char* data,
36 size_t data_len) { 36 size_t data_len) {
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 69
70 int64_t SaveFile::BytesSoFar() const { 70 int64_t SaveFile::BytesSoFar() const {
71 return file_.bytes_so_far(); 71 return file_.bytes_so_far();
72 } 72 }
73 73
74 std::string SaveFile::DebugString() const { 74 std::string SaveFile::DebugString() const {
75 return file_.DebugString(); 75 return file_.DebugString();
76 } 76 }
77 77
78 } // namespace content 78 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/download/save_file.h ('k') | content/browser/download/save_file_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698