Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1429)

Unified Diff: content/browser/download/save_file_manager.h

Issue 2890853002: Downloads: replace BrowserThread::FILE with task scheduler. (Closed)
Patch Set: Address Avi's comments. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/save_file.cc ('k') | content/browser/download/save_file_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/save_file_manager.h
diff --git a/content/browser/download/save_file_manager.h b/content/browser/download/save_file_manager.h
index d6fd762b6891c5d9c71ca343eab0db55d48d92b3..c6066f26686a473e60715195cfd9bc03ba35c20c 100644
--- a/content/browser/download/save_file_manager.h
+++ b/content/browser/download/save_file_manager.h
@@ -22,7 +22,7 @@
// SaveFileManager on the file thread. SaveFileManager will directly
// call SaveFile's method to persist data.
//
-// A typical saving job operation involves multiple threads:
+// A typical saving job operation involves multiple threads and sequences:
//
// Updating an in progress save file
// io_thread
@@ -32,15 +32,15 @@
// |----> data from ---->| |
// | render process | |
// ui_thread | |
-// file_thread (writes to disk)
-// |----> stats ---->|
+// download_task_runner (writes to disk)
+// |----> stats ---->|
// ui_thread (feedback for user)
//
//
// Cancel operations perform the inverse order when triggered by a user action:
// ui_thread (user click)
// |----> cancel command ---->|
-// | | file_thread (close file)
+// | | download_task_runner (close file)
// | |---------------------> cancel command ---->|
// | io_thread (stops net IO
// ui_thread (user close contents) for saving)
« no previous file with comments | « content/browser/download/save_file.cc ('k') | content/browser/download/save_file_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698