Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Unified Diff: runtime/vm/kernel_binary.cc

Issue 2891053003: Add support for converted closures with explicit contexts to VM (Closed)
Patch Set: Update the code according to Martin's comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/kernel_binary.cc
diff --git a/runtime/vm/kernel_binary.cc b/runtime/vm/kernel_binary.cc
index 4757791fad23ef7cb4205e623b7e2e18bfc83688..d9b7d5101b80767587bc819000e0265a83e2332d 100644
--- a/runtime/vm/kernel_binary.cc
+++ b/runtime/vm/kernel_binary.cc
@@ -1151,6 +1151,8 @@ VectorCreation* VectorCreation::ReadFrom(Reader* reader) {
reader->offset() - 1; // -1 to include tag byte.
vector_creation->value_ = reader->ReadUInt();
+ vector_creation->can_stream_ = true;
+
return vector_creation;
}
@@ -1163,7 +1165,7 @@ VectorGet* VectorGet::ReadFrom(Reader* reader) {
vector_get->vector_expression_ = Expression::ReadFrom(reader);
vector_get->index_ = reader->ReadUInt();
- vector_get->can_stream_ = false;
+ vector_get->can_stream_ = true;
return vector_get;
}
@@ -1178,7 +1180,7 @@ VectorSet* VectorSet::ReadFrom(Reader* reader) {
vector_set->index_ = reader->ReadUInt();
vector_set->value_ = Expression::ReadFrom(reader);
- vector_set->can_stream_ = false;
+ vector_set->can_stream_ = vector_set->value_->can_stream();
return vector_set;
}
@@ -1192,7 +1194,7 @@ VectorCopy* VectorCopy::ReadFrom(Reader* reader) {
reader->offset() - 1; // -1 to include tag byte.
vector_copy->vector_expression_ = Expression::ReadFrom(reader);
- vector_copy->can_stream_ = false;
+ vector_copy->can_stream_ = true;
return vector_copy;
}
@@ -1210,7 +1212,7 @@ ClosureCreation* ClosureCreation::ReadFrom(Reader* reader) {
closure_creation->function_type_ =
FunctionType::Cast(DartType::ReadFrom(reader));
- closure_creation->can_stream_ = false;
+ closure_creation->can_stream_ = true;
return closure_creation;
}

Powered by Google App Engine
This is Rietveld 408576698