runtime/vm/kernel_reader.cc - Issue 2891053003: Add support for converted closures with explicit contexts to VM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/kernel_reader.cc

Issue 2891053003: Add support for converted closures with explicit contexts to VM (Closed)

Patch Set: Update the code according to Martin's comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/kernel_reader.cc

diff --git a/runtime/vm/kernel_reader.cc b/runtime/vm/kernel_reader.cc

index f2923d5623bcea97b86d82bf68734d46bad99900..f4aff8ee028ee564e2b44140719353221b718a7d 100644

--- a/runtime/vm/kernel_reader.cc

+++ b/runtime/vm/kernel_reader.cc

@@ -521,7 +521,9 @@ void KernelReader::ReadProcedure(const dart::Library& library,

// no special modifier

break;

}

- ASSERT(kernel_procedure->function()->async_marker() == FunctionNode::kSync);

+ ASSERT(kernel_procedure->function()->async_marker() == FunctionNode::kSync ||

+ kernel_procedure->function()->async_marker() ==

+ FunctionNode::kSyncYielding);

if (native_name != NULL) {

function.set_native_name(*native_name);