Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Unified Diff: media/base/mac/audio_util_mac.cc

Issue 2908073002: Make OS audio buffer size limits visible. (Closed)
Patch Set: Updates based on reviewer feedback. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/mac/audio_util_mac.cc
diff --git a/media/base/mac/audio_util_mac.cc b/media/base/mac/audio_util_mac.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ae4e2d43476a9a0d47e0c22dfb56e99f06bed0d7
--- /dev/null
+++ b/media/base/mac/audio_util_mac.cc
@@ -0,0 +1,27 @@
+// Copyright (c) 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "media/base/mac/audio_util_mac.h"
+#include "media/base/limits.h"
+
+namespace media {
+
+namespace audio_util_mac {
+
+int GetMinAudioBufferSizeForSampleRate(int min_buffer_size, int sample_rate) {
+ int buffer_size = min_buffer_size;
+ if (sample_rate > 48000) {
+ // The default buffer size is too small for higher sample rates and may lead
+ // to glitching. Adjust upwards by multiples of the default size.
+ if (sample_rate <= 96000)
+ buffer_size = 2 * limits::kMinAudioBufferSize;
+ else if (sample_rate <= 192000)
+ buffer_size = 4 * limits::kMinAudioBufferSize;
+ }
+ return buffer_size;
+}
+
+} // namespace audio_util_mac
+
+} // namespace media

Powered by Google App Engine
This is Rietveld 408576698