Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: base/debug/dump_without_crashing.cc

Issue 2909623002: Change DumpProcessWithoutCrash to use load-time dynamic linking (Closed)
Patch Set: forgot to update def file Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/debug/dump_without_crashing.h ('k') | chrome/app/chrome_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/dump_without_crashing.cc
diff --git a/base/debug/dump_without_crashing.cc b/base/debug/dump_without_crashing.cc
index 4b338ca2930b69d110fd545176029aec75f9cd4a..307e64e98f7da70d053c9fd7d3318602d0ee00fb 100644
--- a/base/debug/dump_without_crashing.cc
+++ b/base/debug/dump_without_crashing.cc
@@ -27,6 +27,12 @@ bool DumpWithoutCrashing() {
}
void SetDumpWithoutCrashingFunction(void (CDECL *function)()) {
+#if !defined(COMPONENT_BUILD)
+ // In component builds, the same base is shared between modules
+ // so might be initialized several times. However in non-
+ // component builds this should never happen.
+ DCHECK(!dump_without_crashing_function_);
+#endif
dump_without_crashing_function_ = function;
}
« no previous file with comments | « base/debug/dump_without_crashing.h ('k') | chrome/app/chrome_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698