Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Unified Diff: components/crash/content/app/crashpad_win.cc

Issue 2909623002: Change DumpProcessWithoutCrash to use load-time dynamic linking (Closed)
Patch Set: forgot to update def file Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/crash/content/app/crashpad.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash/content/app/crashpad_win.cc
diff --git a/components/crash/content/app/crashpad_win.cc b/components/crash/content/app/crashpad_win.cc
index 77ccc323567b71aaef640ba1457e07036d14fd30..3946d2a457695fed13c56b1d4db8f4c9ba2f0ec3 100644
--- a/components/crash/content/app/crashpad_win.cc
+++ b/components/crash/content/app/crashpad_win.cc
@@ -157,17 +157,6 @@ base::FilePath PlatformCrashpadInitialization(
return database_path;
}
-// TODO(scottmg): http://crbug.com/546288 These exported functions are for
-// compatibility with how Breakpad worked, but it seems like there's no need to
-// do the CreateRemoteThread() dance with a minor extension of the Crashpad API
-// (to just pass the pid we want a dump for). We should add that and then modify
-// hang_crash_dump_win.cc to work in a more direct manner.
-
-// Used for dumping a process state when there is no crash.
-extern "C" void __declspec(dllexport) __cdecl DumpProcessWithoutCrash() {
- CRASHPAD_SIMULATE_CRASH();
-}
-
namespace {
// We need to prevent ICF from folding DumpProcessForHungInputThread(),
@@ -188,7 +177,7 @@ DWORD WINAPI DumpProcessForHungInputThread(void* crash_keys_str) {
base::debug::SetCrashKeyValue(crash_key.first, crash_key.second);
}
}
- DumpProcessWithoutCrash();
+ DumpWithoutCrashing();
return 0;
}
@@ -201,7 +190,7 @@ DWORD WINAPI DumpProcessForHungInputNoCrashKeysThread(void* reason) {
"hung-reason", base::IntToString(reinterpret_cast<int>(reason)));
#pragma warning(pop)
- DumpProcessWithoutCrash();
+ DumpWithoutCrashing();
return 0;
}
« no previous file with comments | « components/crash/content/app/crashpad.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698