Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1518)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_utility.cc

Issue 2911193002: Implement timing frames. (Closed)
Patch Set: Implement Holmer@ comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc ('k') | webrtc/modules/video_coding/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtp_utility.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_utility.cc b/webrtc/modules/rtp_rtcp/source/rtp_utility.cc
index 06786cb27afdb5b878645ad637c7d43d7af90bae..f959087c99deee8daf8b4fbf39061b2ba7d2e5f7 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_utility.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtp_utility.cc
@@ -10,8 +10,6 @@
#include "webrtc/modules/rtp_rtcp/source/rtp_utility.h"
-#include <string.h>
-
#include "webrtc/base/logging.h"
#include "webrtc/modules/rtp_rtcp/include/rtp_cvo.h"
#include "webrtc/modules/rtp_rtcp/source/byte_io.h"
@@ -253,6 +251,9 @@ bool RtpHeaderParser::Parse(RTPHeader* header,
header->extension.hasVideoContentType = false;
header->extension.videoContentType = VideoContentType::UNSPECIFIED;
+ header->extension.has_video_timing = false;
+ header->extension.video_timing = {0u, 0u, 0u, 0u, 0u, 0u, false};
+
if (X) {
/* RTP header extension, RFC 3550.
0 1 2 3
@@ -464,6 +465,16 @@ void RtpHeaderParser::ParseOneByteExtensionHeader(
}
break;
}
+ case kRtpExtensionVideoTiming: {
+ if (len != VideoTimingExtension::kValueSizeBytes - 1) {
+ LOG(LS_WARNING) << "Incorrect video timing len: " << len;
+ return;
+ }
+ header->extension.has_video_timing = true;
+ VideoTimingExtension::Parse(rtc::MakeArrayView(ptr, len + 1),
+ &header->extension.video_timing);
+ break;
+ }
case kRtpExtensionRtpStreamId: {
header->extension.stream_id.Set(rtc::MakeArrayView(ptr, len + 1));
break;
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc ('k') | webrtc/modules/video_coding/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698