Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2251)

Unified Diff: ios/clean/chrome/browser/ui/overlay_service/internal/BUILD.gn

Issue 2921833002: [iOS Clean] Created OverlayService.
Patch Set: rebase & Mark's comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/ui/overlay_service/internal/BUILD.gn
diff --git a/ios/clean/chrome/browser/ui/web_contents/BUILD.gn b/ios/clean/chrome/browser/ui/overlay_service/internal/BUILD.gn
similarity index 51%
copy from ios/clean/chrome/browser/ui/web_contents/BUILD.gn
copy to ios/clean/chrome/browser/ui/overlay_service/internal/BUILD.gn
index b10606f62700aa17d9fb7d83de66640d2c5a52d0..c3e1750d048506e9daaf62ae277df64929322bbb 100644
--- a/ios/clean/chrome/browser/ui/web_contents/BUILD.gn
+++ b/ios/clean/chrome/browser/ui/overlay_service/internal/BUILD.gn
@@ -2,57 +2,58 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-source_set("web_contents") {
+source_set("internal") {
marq (ping after 24h) 2017/06/23 10:42:01 I'm not sure that the internal/ subdirectory is us
sources = [
- "web_contents_mediator.h",
- "web_contents_mediator.mm",
- "web_coordinator.h",
- "web_coordinator.mm",
+ "browser_coordinator+overlay_support.mm",
+ "browser_overlay_queue.h",
+ "browser_overlay_queue.mm",
+ "overlay_queue.h",
+ "overlay_queue.mm",
+ "overlay_queue_observer.h",
+ "overlay_scheduler.h",
+ "overlay_scheduler.mm",
+ "overlay_service_factory.mm",
+ "overlay_service_impl.h",
+ "overlay_service_impl.mm",
+ "web_state_overlay_queue.h",
+ "web_state_overlay_queue.mm",
]
configs += [ "//build/config/compiler:enable_arc" ]
deps = [
- ":web_contents_ui",
- "//ios/chrome/browser",
+ "//base",
+ "//components/keyed_service/core",
+ "//components/keyed_service/ios",
+ "//ios/chrome/browser/browser_state",
"//ios/chrome/browser/web_state_list",
"//ios/clean/chrome/browser/ui/commands",
- "//ios/clean/chrome/browser/ui/context_menu",
+ "//ios/clean/chrome/browser/ui/overlay_service:overlay_service_headers",
"//ios/shared/chrome/browser/ui/browser_list",
"//ios/shared/chrome/browser/ui/commands",
"//ios/shared/chrome/browser/ui/coordinators",
"//ios/web",
- "//ui/base",
- "//url",
]
}
-source_set("web_contents_ui") {
- sources = [
- "web_contents_consumer.h",
- "web_contents_view_controller.h",
- "web_contents_view_controller.mm",
- ]
-
- configs += [ "//build/config/compiler:enable_arc" ]
-}
-
source_set("unit_tests") {
testonly = true
sources = [
- "web_contents_mediator_unittest.mm",
+ "overlay_queue_unittest.mm",
]
configs += [ "//build/config/compiler:enable_arc" ]
deps = [
- ":web_contents",
- ":web_contents_ui",
+ ":internal",
"//base",
"//base/test:test_support",
"//ios/chrome/browser/web_state_list",
"//ios/chrome/browser/web_state_list:test_support",
"//ios/chrome/test/base",
+ "//ios/clean/chrome/browser/ui/commands",
+ "//ios/clean/chrome/browser/ui/overlay_service",
+ "//ios/shared/chrome/browser/ui/coordinators",
"//ios/web/public/test/fakes",
"//testing/gtest",
]

Powered by Google App Engine
This is Rietveld 408576698