Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2923103002: Allow GRD reader to process a custom GRDP file stored in a folder different from its parent GRD fil… (Closed)

Created:
3 years, 6 months ago by xiaoshu
Modified:
3 years, 5 months ago
Reviewers:
Nico, benrg, Jói
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow GRD reader to process a custom GRDP file stored in a folder different from its parent GRD file. As of today, GRIT assumes that files referenced from the GRD file are relative to a path stored in the root <grit> node. This change fixes it by allowing grd reader to process a GRDP file stored in an arbitrary path as long as the file exists. BUG=729620 TEST=python tools/grit/grit.py unit R=benrg@chromium.org,joi@chromium.org,thakis@chromium.org Review-Url: https://codereview.chromium.org/2923103002 Cr-Commit-Position: refs/heads/master@{#482829} Committed: https://chromium.googlesource.com/chromium/src/+/d93265c38767d0886c7bddcfaa643d8b3aa7c224

Patch Set 1 #

Patch Set 2 : Correct author name typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -16 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/grit/grit/exception.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/grit/grit/grd_reader.py View 1 chunk +4 lines, -7 lines 0 comments Download
M tools/grit/grit/grd_reader_unittest.py View 4 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
xiaoshu
Friendly ping? :)
3 years, 6 months ago (2017-06-20 21:58:51 UTC) #1
Jói
On 2017/06/20 21:58:51, xiaoshu wrote: > Friendly ping? :) This looks OK to me, but ...
3 years, 6 months ago (2017-06-22 18:23:24 UTC) #2
Nico
looks fine, but can you say what you need this for? having grdp files next ...
3 years, 6 months ago (2017-06-22 19:02:31 UTC) #3
xiaoshu
On 2017/06/22 19:02:31, Nico wrote: > looks fine, but can you say what you need ...
3 years, 6 months ago (2017-06-22 21:56:25 UTC) #4
Nico
On 2017/06/22 21:56:25, xiaoshu wrote: > On 2017/06/22 19:02:31, Nico wrote: > > looks fine, ...
3 years, 6 months ago (2017-06-22 21:59:36 UTC) #5
xiaoshu
On 2017/06/22 21:59:36, Nico (vacation Jun 30-Jul 11) wrote: > On 2017/06/22 21:56:25, xiaoshu wrote: ...
3 years, 5 months ago (2017-06-27 17:14:29 UTC) #6
Nico
lgtm
3 years, 5 months ago (2017-06-27 19:09:33 UTC) #7
xiaoshu
On 2017/06/27 19:09:33, Nico (vacation Jun 30-Jul 11) wrote: > lgtm Thank you!
3 years, 5 months ago (2017-06-27 19:30:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923103002/1
3 years, 5 months ago (2017-06-27 21:24:40 UTC) #10
commit-bot: I haz the power
The author xiaoshu@amazon.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
3 years, 5 months ago (2017-06-27 21:24:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923103002/20001
3 years, 5 months ago (2017-06-28 00:46:04 UTC) #15
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 00:58:43 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d93265c38767d0886c7bddcfaa64...

Powered by Google App Engine
This is Rietveld 408576698