Remove support for some device constraints from SelectSettings.

Remove support for some device constraints from SelectSettings.

This CL removes support for the sampleRate, sampleSize and channelCount
constraints from SelectSettingsAudioCapture, to be used by getUserMedia.
Reasons:
* Support was limited to aid in device selection. Setting track
  parameters was not supported. 
* The device selection code considered only the capabilities of
  the device as reported by its native hardware parameters but it did
  not consider extra capabilities that can be added by software (e.g.,
  resampling, converting a stereo track to mono, etc.).
  Not taking this into account could lead to spec violations since the
  final settings of a track might differ from the hardware settings of
  the device used to produce the track.

Proper integration of these constraints is being tracked by
crbug.com/731170.

This CL also has a couple of minor drive-by fixes.

BUG=657733
Review-Url: https://codereview.chromium.org/2940553005
Cr-Commit-Position: refs/heads/master@{#480531}
Committed: https://chromium.googlesource.com/chromium/src/+/08158e579c68b88587555a4338ca39d20a4c3fab

[Guido Urdaneta, 2017-06-13 18:32:53]

Description was changed from

==========
Remove support for some device constraints from SelectSettings.

This CL removes support for the sampleRate, sampleSize and channelCount
constraints from SelectSettingsAudioCapture, to be used by getUserMedia.
Reasons:
* Support was limited to aid in device selection, but not in setting
  track parameters.
* While the device selection worked, it considered only the capabilities
  of the device as reported by its native hardware parameters but it did
  not consider extra capabilities that can be added by software (e.g.,
  resampling, converting a stereo track to mono, etc.).
  Not taking this into account could lead to spec violations since the
  final settings of a track might differ from the hardware settings of
  the device used to produce the track.
  Proper integration of these constraints is being tracked by
  crbug.com/731170.

BUG=657733
==========

to

==========
Remove support for some device constraints from SelectSettings.

This CL removes support for the sampleRate, sampleSize and channelCount
constraints from SelectSettingsAudioCapture, to be used by getUserMedia.
Reasons:
* Support was limited to aid in device selection. Setting track
  parameters was not supported. 
* The device selection code considered only the capabilities of
  the device as reported by its native hardware parameters but it did
  not consider extra capabilities that can be added by software (e.g.,
  resampling, converting a stereo track to mono, etc.).
  Not taking this into account could lead to spec violations since the
  final settings of a track might differ from the hardware settings of
  the device used to produce the track.

Proper integration of these constraints is being tracked by
crbug.com/731170.

This CL also has a couple of minor drive-by fixes.

BUG=657733
==========

[Guido Urdaneta, 2017-06-13 18:32:54]

guidou@chromium.org changed reviewers:
+ hbos@chromium.org

[Guido Urdaneta, 2017-06-13 18:33:37]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 18:34:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 20:47:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 20:47:23]

Dry run: This issue passed the CQ dry run.

[Guido Urdaneta, 2017-06-13 21:09:08]

Hi, PTAL

[hbos_chromium, 2017-06-16 15:58:39]

lgtm

https://codereview.chromium.org/2940553005/diff/1/content/renderer/media/medi...
File content/renderer/media/media_stream_constraints_util_audio_unittest.cc
(left):

https://codereview.chromium.org/2940553005/diff/1/content/renderer/media/medi...
content/renderer/media/media_stream_constraints_util_audio_unittest.cc:1150:
TEST_P(MediaStreamConstraintsUtilAudioTest, AdvancedSelfConflictingConstraint) {
Conflicting constraints is still useful to test. Can you still have this test,
but conflicting constraints other than the ones removed?

https://codereview.chromium.org/2940553005/diff/1/content/renderer/media/medi...
content/renderer/media/media_stream_constraints_util_audio_unittest.cc:1167:
AdvancedConflictingDeviceConstraint) {
Ditto.

[Guido Urdaneta, 2017-06-16 16:09:19]

https://codereview.chromium.org/2940553005/diff/1/content/renderer/media/medi...
File content/renderer/media/media_stream_constraints_util_audio_unittest.cc
(left):

https://codereview.chromium.org/2940553005/diff/1/content/renderer/media/medi...
content/renderer/media/media_stream_constraints_util_audio_unittest.cc:1150:
TEST_P(MediaStreamConstraintsUtilAudioTest, AdvancedSelfConflictingConstraint) {
On 2017/06/16 15:58:39, hbos_chromium wrote:
> Conflicting constraints is still useful to test. Can you still have this test,
> but conflicting constraints other than the ones removed?

There are conflicting tests with other constraints. See
AdvancedConflictingMiddleConstraints and AdvancedConflictingLastConstraint.

These two cannot be remade with other constraints because they refer to having
different constraints that cannot be satisfied in combination,
 which only applied to device constraints (e.g. a sampleRate/channelCount
combination that no device has).
Among the remaining constraints, there is no pair of constraints that cannot be
satisfied in combination (except for googEchoCancellation and echoCancellation,
but that's tested).

[Guido Urdaneta, 2017-06-19 14:46:55]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 14:47:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 16:42:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 16:42:46]

Dry run: This issue passed the CQ dry run.

[Guido Urdaneta, 2017-06-19 18:38:20]

The CQ bit was checked by guidou@chromium.org

[commit-bot: I haz the power, 2017-06-19 18:38:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 19:37:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497897500223150, "parent_rev":
"b0e0329d8aac9201e6e162eb03524e39a85b454d", "commit_rev":
"08158e579c68b88587555a4338ca39d20a4c3fab"}

[commit-bot: I haz the power, 2017-06-19 19:37:57]

Description was changed from

==========
Remove support for some device constraints from SelectSettings.

This CL removes support for the sampleRate, sampleSize and channelCount
constraints from SelectSettingsAudioCapture, to be used by getUserMedia.
Reasons:
* Support was limited to aid in device selection. Setting track
  parameters was not supported. 
* The device selection code considered only the capabilities of
  the device as reported by its native hardware parameters but it did
  not consider extra capabilities that can be added by software (e.g.,
  resampling, converting a stereo track to mono, etc.).
  Not taking this into account could lead to spec violations since the
  final settings of a track might differ from the hardware settings of
  the device used to produce the track.

Proper integration of these constraints is being tracked by
crbug.com/731170.

This CL also has a couple of minor drive-by fixes.

BUG=657733
==========

to

==========
Remove support for some device constraints from SelectSettings.

This CL removes support for the sampleRate, sampleSize and channelCount
constraints from SelectSettingsAudioCapture, to be used by getUserMedia.
Reasons:
* Support was limited to aid in device selection. Setting track
  parameters was not supported. 
* The device selection code considered only the capabilities of
  the device as reported by its native hardware parameters but it did
  not consider extra capabilities that can be added by software (e.g.,
  resampling, converting a stereo track to mono, etc.).
  Not taking this into account could lead to spec violations since the
  final settings of a track might differ from the hardware settings of
  the device used to produce the track.

Proper integration of these constraints is being tracked by
crbug.com/731170.

This CL also has a couple of minor drive-by fixes.

BUG=657733

Review-Url: https://codereview.chromium.org/2940553005
Cr-Commit-Position: refs/heads/master@{#480531}
Committed:
https://chromium.googlesource.com/chromium/src/+/08158e579c68b88587555a4338ca...
==========

[commit-bot: I haz the power, 2017-06-19 19:37:58]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/08158e579c68b88587555a4338ca...