Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: content/browser/renderer_host/media/audio_input_renderer_host.h

Issue 2941773002: Added initial muted state to stream creation callback, to avoid races. (Closed)
Patch Set: Added mute information to DoCompleteCreation log message. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/media/audio_input_renderer_host.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // AudioInputRendererHost serves audio related requests from audio capturer 5 // AudioInputRendererHost serves audio related requests from audio capturer
6 // which lives inside the render process and provide access to audio hardware. 6 // which lives inside the render process and provide access to audio hardware.
7 // 7 //
8 // Create stream sequence (AudioInputController = AIC): 8 // Create stream sequence (AudioInputController = AIC):
9 // 9 //
10 // AudioInputHostMsg_CreateStream -> OnCreateStream -> AIC::CreateLowLatency -> 10 // AudioInputHostMsg_CreateStream -> OnCreateStream -> AIC::CreateLowLatency ->
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 void EnableDebugRecording(const base::FilePath& file); 103 void EnableDebugRecording(const base::FilePath& file);
104 void DisableDebugRecording(); 104 void DisableDebugRecording();
105 #endif 105 #endif
106 106
107 // BrowserMessageFilter implementation. 107 // BrowserMessageFilter implementation.
108 void OnChannelClosing() override; 108 void OnChannelClosing() override;
109 void OnDestruct() const override; 109 void OnDestruct() const override;
110 bool OnMessageReceived(const IPC::Message& message) override; 110 bool OnMessageReceived(const IPC::Message& message) override;
111 111
112 // AudioInputController::EventHandler implementation. 112 // AudioInputController::EventHandler implementation.
113 void OnCreated(media::AudioInputController* controller) override; 113 void OnCreated(media::AudioInputController* controller,
114 bool initially_muted) override;
114 void OnError(media::AudioInputController* controller, 115 void OnError(media::AudioInputController* controller,
115 media::AudioInputController::ErrorCode error_code) override; 116 media::AudioInputController::ErrorCode error_code) override;
116 void OnLog(media::AudioInputController* controller, 117 void OnLog(media::AudioInputController* controller,
117 const std::string& message) override; 118 const std::string& message) override;
118 void OnMuted(media::AudioInputController* controller, bool is_muted) override; 119 void OnMuted(media::AudioInputController* controller, bool is_muted) override;
119 120
120 // Sets the PID renderer. This is used for constructing the debug recording 121 // Sets the PID renderer. This is used for constructing the debug recording
121 // filename. 122 // filename.
122 void set_renderer_pid(int32_t renderer_pid); 123 void set_renderer_pid(int32_t renderer_pid);
123 124
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 159
159 // Close the audio stream referenced by |stream_id|. 160 // Close the audio stream referenced by |stream_id|.
160 void OnCloseStream(int stream_id); 161 void OnCloseStream(int stream_id);
161 162
162 // Set the volume of the audio stream referenced by |stream_id|. 163 // Set the volume of the audio stream referenced by |stream_id|.
163 void OnSetVolume(int stream_id, double volume); 164 void OnSetVolume(int stream_id, double volume);
164 165
165 // Complete the process of creating an audio input stream. This will set up 166 // Complete the process of creating an audio input stream. This will set up
166 // the shared memory or shared socket in low latency mode and send the 167 // the shared memory or shared socket in low latency mode and send the
167 // NotifyStreamCreated message to the peer. 168 // NotifyStreamCreated message to the peer.
168 void DoCompleteCreation(media::AudioInputController* controller); 169 void DoCompleteCreation(media::AudioInputController* controller,
170 bool initially_muted);
169 171
170 // Send a state change message to the renderer. 172 // Send a state change message to the renderer.
171 void DoSendRecordingMessage(media::AudioInputController* controller); 173 void DoSendRecordingMessage(media::AudioInputController* controller);
172 174
173 // Handle error coming from audio stream. 175 // Handle error coming from audio stream.
174 void DoHandleError(media::AudioInputController* controller, 176 void DoHandleError(media::AudioInputController* controller,
175 media::AudioInputController::ErrorCode error_code); 177 media::AudioInputController::ErrorCode error_code);
176 178
177 // Log audio level of captured audio stream. 179 // Log audio level of captured audio stream.
178 void DoLog(media::AudioInputController* controller, 180 void DoLog(media::AudioInputController* controller,
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 media::UserInputMonitor* const user_input_monitor_; 258 media::UserInputMonitor* const user_input_monitor_;
257 259
258 std::unique_ptr<media::AudioLog> audio_log_; 260 std::unique_ptr<media::AudioLog> audio_log_;
259 261
260 DISALLOW_COPY_AND_ASSIGN(AudioInputRendererHost); 262 DISALLOW_COPY_AND_ASSIGN(AudioInputRendererHost);
261 }; 263 };
262 264
263 } // namespace content 265 } // namespace content
264 266
265 #endif // CONTENT_BROWSER_RENDERER_HOST_MEDIA_AUDIO_INPUT_RENDERER_HOST_H_ 267 #endif // CONTENT_BROWSER_RENDERER_HOST_MEDIA_AUDIO_INPUT_RENDERER_HOST_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/renderer_host/media/audio_input_renderer_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698