Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2942193002: [signin] Generate OAuth token on Dice Signin responses (Closed)

Created:
3 years, 6 months ago by droger
Modified:
3 years, 6 months ago
Reviewers:
msarda
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[signin] Generate OAuth token on Dice Signin responses Introduces the DiceResponseHandler class to handle the Dice responses, which is a new profile keyed service. In this CL, only the SIGNIN response is implemented, and triggers a OAuth2 token request. BUG=730589 Review-Url: https://codereview.chromium.org/2942193002 Cr-Commit-Position: refs/heads/master@{#481518} Committed: https://chromium.googlesource.com/chromium/src/+/7c51029f7f3e25be2a0d2a9c54263c43660990be

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : fix fetcher lifetime #

Patch Set 4 : Standalone keyed service #

Patch Set 5 : Minor cleanup #

Patch Set 6 : Pass OAuth2TokenServiceDelegate directly #

Total comments: 9

Patch Set 7 : Review comments #

Total comments: 8

Patch Set 8 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -9 lines) Patch
M chrome/browser/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/signin/chrome_signin_helper.cc View 1 2 3 4 5 5 chunks +36 lines, -9 lines 0 comments Download
A chrome/browser/signin/dice_response_handler.h View 1 2 3 4 5 6 7 1 chunk +57 lines, -0 lines 0 comments Download
A chrome/browser/signin/dice_response_handler.cc View 1 2 3 4 5 6 7 1 chunk +148 lines, -0 lines 0 comments Download

Messages

Total messages: 34 (25 generated)
droger
Not sure how to test this though, I guess this would have to be a ...
3 years, 6 months ago (2017-06-16 13:14:04 UTC) #7
droger
Oops, looks like bots are failing, CL is not ready yet for review...
3 years, 6 months ago (2017-06-16 13:30:55 UTC) #10
droger
This should be ready for review now.
3 years, 6 months ago (2017-06-16 14:24:15 UTC) #14
msarda
https://codereview.chromium.org/2942193002/diff/100001/chrome/browser/signin/dice_response_handler.cc File chrome/browser/signin/dice_response_handler.cc (right): https://codereview.chromium.org/2942193002/diff/100001/chrome/browser/signin/dice_response_handler.cc#newcode87 chrome/browser/signin/dice_response_handler.cc:87: case signin::DiceAction::SIGNIN: In Chrome there are multiple notions of ...
3 years, 6 months ago (2017-06-20 08:45:23 UTC) #21
droger
Thanks. https://codereview.chromium.org/2942193002/diff/100001/chrome/browser/signin/dice_response_handler.cc File chrome/browser/signin/dice_response_handler.cc (right): https://codereview.chromium.org/2942193002/diff/100001/chrome/browser/signin/dice_response_handler.cc#newcode87 chrome/browser/signin/dice_response_handler.cc:87: case signin::DiceAction::SIGNIN: On 2017/06/20 08:45:22, msarda wrote: > ...
3 years, 6 months ago (2017-06-20 11:01:28 UTC) #24
msarda
lgtm https://codereview.chromium.org/2942193002/diff/120001/chrome/browser/signin/dice_response_handler.cc File chrome/browser/signin/dice_response_handler.cc (right): https://codereview.chromium.org/2942193002/diff/120001/chrome/browser/signin/dice_response_handler.cc#newcode112 chrome/browser/signin/dice_response_handler.cc:112: const std::string& authorization_code) { Let's DCHECK that gaia_id, ...
3 years, 6 months ago (2017-06-22 09:11:31 UTC) #27
droger
Thanks! https://codereview.chromium.org/2942193002/diff/120001/chrome/browser/signin/dice_response_handler.cc File chrome/browser/signin/dice_response_handler.cc (right): https://codereview.chromium.org/2942193002/diff/120001/chrome/browser/signin/dice_response_handler.cc#newcode112 chrome/browser/signin/dice_response_handler.cc:112: const std::string& authorization_code) { On 2017/06/22 09:11:31, msarda ...
3 years, 6 months ago (2017-06-22 12:39:07 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2942193002/140001
3 years, 6 months ago (2017-06-22 12:39:39 UTC) #31
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 13:51:43 UTC) #34
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/7c51029f7f3e25be2a0d2a9c5426...

Powered by Google App Engine
This is Rietveld 408576698