Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2945783002: Get rid of redundant default parameter from NextLeafWithSameEditability() (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of redundant default parameter from NextLeafWithSameEditability() This patch gets rid of default parameter from |NextLeafWithSameEditability()| since all call sites pass don't use default parameter for improving readability. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2945783002 Cr-Commit-Position: refs/heads/master@{#480645} Committed: https://chromium.googlesource.com/chromium/src/+/32414cb1db2f158e0ebb4f5b601c9fc1a5146ed7

Patch Set 1 : 2017-06-19T17:20:50 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-19 09:08:12 UTC) #5
Xiaocheng
lgtm
3 years, 6 months ago (2017-06-19 17:06:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2945783002/1
3 years, 6 months ago (2017-06-19 23:41:13 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 23:46:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/32414cb1db2f158e0ebb4f5b601c...

Powered by Google App Engine
This is Rietveld 408576698