Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: ios/shared/chrome/browser/ui/coordinators/browser_coordinator_unittest.mm

Issue 2948463002: [iOS Clean] Removed old overlay implementation.
Patch Set: rebase & Mark's comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/shared/chrome/browser/ui/coordinators/browser_coordinator+internal.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/shared/chrome/browser/ui/coordinators/browser_coordinator_unittest.mm
diff --git a/ios/shared/chrome/browser/ui/coordinators/browser_coordinator_unittest.mm b/ios/shared/chrome/browser/ui/coordinators/browser_coordinator_unittest.mm
index b9ca22fce2e31df03feb3c95c7668a8068d0304a..a788ce006d59e643274683b00907f9ea16d57b94 100644
--- a/ios/shared/chrome/browser/ui/coordinators/browser_coordinator_unittest.mm
+++ b/ios/shared/chrome/browser/ui/coordinators/browser_coordinator_unittest.mm
@@ -121,55 +121,6 @@ - (BOOL)canAddOverlayCoordinator:(BrowserCoordinator*)overlayCoordinator {
EXPECT_EQ(otherParent, otherChild.parentCoordinator);
}
-TEST_F(BrowserCoordinatorTest, TestOverlay) {
- TestCoordinator* parent = [[TestCoordinator alloc] init];
- TestCoordinator* child = [[TestCoordinator alloc] init];
- TestCoordinator* grandchild = [[TestCoordinator alloc] init];
- TestCoordinator* overlay = [[TestCoordinator alloc] init];
- TestCoordinator* secondOverlay = [[TestCoordinator alloc] init];
-
- EXPECT_TRUE([parent canAddOverlayCoordinator:overlay]);
- [parent addChildCoordinator:child];
- [child addChildCoordinator:grandchild];
- EXPECT_FALSE([parent canAddOverlayCoordinator:overlay]);
- EXPECT_FALSE([child canAddOverlayCoordinator:overlay]);
- EXPECT_TRUE([grandchild canAddOverlayCoordinator:overlay]);
- EXPECT_FALSE([grandchild canAddOverlayCoordinator:child]);
-
- EXPECT_FALSE(overlay.overlaying);
- [parent addOverlayCoordinator:overlay];
- EXPECT_TRUE(overlay.overlaying);
- EXPECT_EQ(overlay, parent.overlayCoordinator);
- EXPECT_EQ(overlay, child.overlayCoordinator);
- EXPECT_EQ(overlay, grandchild.overlayCoordinator);
- EXPECT_TRUE([grandchild.children containsObject:overlay]);
- EXPECT_EQ(grandchild, overlay.parentCoordinator);
-
- // Shouldn't be able to add a second overlaying coordinator.
- EXPECT_FALSE([grandchild canAddOverlayCoordinator:secondOverlay]);
- EXPECT_FALSE(secondOverlay.overlaying);
- [parent addOverlayCoordinator:secondOverlay];
- EXPECT_FALSE(secondOverlay.overlaying);
-
- [child removeOverlayCoordinator];
- EXPECT_FALSE(overlay.overlaying);
- EXPECT_EQ(nil, parent.overlayCoordinator);
- EXPECT_EQ(nil, child.overlayCoordinator);
- EXPECT_EQ(nil, grandchild.overlayCoordinator);
- EXPECT_FALSE([grandchild.children containsObject:overlay]);
- EXPECT_EQ(nil, overlay.parentCoordinator);
-
- // An implementation that doesn't allow any overlays shouldn't get one.
- NonOverlayableCoordinator* noOverlays =
- [[NonOverlayableCoordinator alloc] init];
- TestCoordinator* thirdOverlay = [[TestCoordinator alloc] init];
-
- EXPECT_FALSE([noOverlays canAddOverlayCoordinator:thirdOverlay]);
- EXPECT_FALSE(thirdOverlay.overlaying);
- [noOverlays addOverlayCoordinator:thirdOverlay];
- EXPECT_FALSE(thirdOverlay.overlaying);
-}
-
TEST_F(BrowserCoordinatorTest, AddedRemoved) {
TestCoordinator* parent = [[TestCoordinator alloc] init];
TestCoordinator* child = [[TestCoordinator alloc] init];
« no previous file with comments | « ios/shared/chrome/browser/ui/coordinators/browser_coordinator+internal.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698