DescriptionImplement a skeleton of the Superfish interstitial
This CL adds SuperfishBlockingPage and SuperfishErrorUI classes to display the
Superfish interstitial. SSLErrorHandler checks for the Superfish certificate
fingerprint and uses a SuperfishBlockingPage (a subclass of SSLBlockingPage)
when it's present.
The strings displayed by SuperfishErrorUI are stubs for now; those will be
filled in to match the mocks in a follow-up.
SSLBlockingPage is modified a bit to allow a subclass that uses its own subclass
of SSLErrorUI. And SSLErrorUI is modified a bit to allow a subclass that uses
special strings.
The certificate error report format is updated to report when the Superfish
interstitial is shown (similar to how clock and captive portal interstitials are
reported). Certificate reporting for the Superfish interstitial is missing a
test; see https://crbug.com/735803.
This is all gated behind the SuperfishInterstitial Finch feature.
BUG=734590
Review-Url: https://codereview.chromium.org/2949003003
Cr-Commit-Position: refs/heads/master@{#481781}
Committed: https://chromium.googlesource.com/chromium/src/+/5cbbc0943d80dbd7ba1e89694f921d61ff12e3ab
Patch Set 1 #
Total comments: 17
Patch Set 2 : meacer comments #
Total comments: 18
Patch Set 3 : meacer comments rd 2 #Patch Set 4 : fix excessive output test problem #Patch Set 5 : actually fix excessive output problem #Dependent Patchsets: Messages
Total messages: 29 (20 generated)
|