Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: third_party/WebKit/Source/core/page/ValidationMessageClientImpl.h

Issue 2949593003: Move navigation-induced hiding of form-validation-bubble to the browser process. (Closed)
Patch Set: Remove now unnecessary call from WebContentsImpl::RenderViewTerminated to delegate_->HideValidation… Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 void CheckAnchorStatus(TimerBase*); 56 void CheckAnchorStatus(TimerBase*);
57 LocalFrameView* CurrentView(); 57 LocalFrameView* CurrentView();
58 58
59 void ShowValidationMessage(const Element& anchor, 59 void ShowValidationMessage(const Element& anchor,
60 const String& message, 60 const String& message,
61 TextDirection message_dir, 61 TextDirection message_dir,
62 const String& sub_message, 62 const String& sub_message,
63 TextDirection sub_message_dir) override; 63 TextDirection sub_message_dir) override;
64 void HideValidationMessage(const Element& anchor) override; 64 void HideValidationMessage(const Element& anchor) override;
65 bool IsValidationMessageVisible(const Element& anchor) override; 65 bool IsValidationMessageVisible(const Element& anchor) override;
66 void WillUnloadDocument(const Document&) override;
67 void DocumentDetached(const Document&) override;
68 void WillBeDestroyed() override; 66 void WillBeDestroyed() override;
69 67
70 // PopupOpeningObserver function 68 // PopupOpeningObserver function
71 void WillOpenPopup() override; 69 void WillOpenPopup() override;
72 70
73 WebViewBase& web_view_; 71 WebViewBase& web_view_;
74 Member<const Element> current_anchor_; 72 Member<const Element> current_anchor_;
75 String message_; 73 String message_;
76 IntRect last_anchor_rect_in_screen_; 74 IntRect last_anchor_rect_in_screen_;
77 float last_page_scale_factor_; 75 float last_page_scale_factor_;
78 double finish_time_; 76 double finish_time_;
79 std::unique_ptr<TimerBase> timer_; 77 std::unique_ptr<TimerBase> timer_;
80 }; 78 };
81 79
82 } // namespace blink 80 } // namespace blink
83 81
84 #endif 82 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698