Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2949593003: Move navigation-induced hiding of form-validation-bubble to the browser process. (Closed)
Patch Set: Remove now unnecessary call from WebContentsImpl::RenderViewTerminated to delegate_->HideValidation… Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_impl_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 40429d51814846c69671b3bce27a1af955e1452b..088381683c9ac16a6939c50b427de893a92a8f32 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -987,6 +987,8 @@ void WebContentsImpl::CancelActiveAndPendingDialogs() {
}
if (browser_plugin_embedder_)
browser_plugin_embedder_->CancelGuestDialogs();
+ if (delegate_)
+ delegate_->HideValidationMessage(this);
}
void WebContentsImpl::ClosePage() {
@@ -4675,9 +4677,6 @@ void WebContentsImpl::RenderViewTerminated(RenderViewHost* rvh,
// Cancel any visible dialogs so they are not left dangling over the sad tab.
CancelActiveAndPendingDialogs();
- if (delegate_)
- delegate_->HideValidationMessage(this);
-
audio_stream_monitor_.RenderProcessGone(rvh->GetProcess()->GetID());
// Reset the loading progress. TODO(avi): What does it mean to have a
« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_impl_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698