PDFExtensionTest: Stop using chrome:// URL to load mock-interactions.js

chrome/browser/pdf/pdf_extension_test.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <vector>
 
 #include "base/base_paths.h"
 #include "base/files/file_enumerator.h"
@@ skipping 125 matching lines @@
     GURL url(embedded_test_server()->GetURL("/pdf/" + pdf_filename));
 
     // It should be good enough to just navigate to the URL. But loading up the
     // BrowserPluginGuest seems to happen asynchronously as there was flakiness
     // being seen due to the BrowserPluginGuest not being available yet (see
     // crbug.com/498077). So instead use |LoadPdf| which ensures that the PDF is
     // loaded before continuing.
     WebContents* guest_contents = LoadPdfGetGuestContents(url);
     ASSERT_TRUE(guest_contents);
     std::string test_util_js;
+    std::string mock_interactions_js;
 
     {
       base::ThreadRestrictions::ScopedAllowIO allow_io;
       base::FilePath test_data_dir;
       PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir);
       test_data_dir = test_data_dir.Append(FILE_PATH_LITERAL("pdf"));
       base::FilePath test_util_path = test_data_dir.AppendASCII("test_util.js");
       ASSERT_TRUE(base::ReadFileToString(test_util_path, &test_util_js));
 
+      base::FilePath source_root_dir;
+      PathService::Get(base::DIR_SOURCE_ROOT, &source_root_dir);
+      base::FilePath mock_interactions_path = source_root_dir.Append(
+          FILE_PATH_LITERAL("third_party/polymer/v1_0/components-chromium/"

[Lei Zhang, 2017/06/24 00:13:46]

Is it possible to use IDR_POLYMER_1_0_IRON_TEST_HELPERS_MOCK_INTERACTIONS_JS
instead of referring to it by path? If yes, would that be better?

[dpapad, 2017/06/24 00:40:53]

This would defeat the purpose of this CL which is to remove mock-interactions.js
from any grd file (and therefore not having it shipped with Chrome), see next CL
which actually does this,
https://codereview.chromium.org/2949313002/diff/80001/ui/webui/resources/poly....

[Lei Zhang, 2017/06/24 00:47:59]

What about moving it to browser_tests.pak? i.e. move the grit entry into
chrome/test/data/webui_test_resources.grd.

[dpapad, 2017/06/24 01:07:38]

I can explore that if preferable, but at first glance it seems that
https://cs.chromium.org/chromium/src/chrome/test/data/webui_test_resources.grd
should only contain files that are in a subtree of its location, not from a
random third party location. Also technically the PDF plugin tests are not WebUI
tests. It would probably be better to create a
ui/webui/resources/polymer_test_resources.grdp if we want to follow the GRIT
approach.

My understanding is that both GRIT and GN provide a way to manage dependencies,
but GRIT also does a bunch of other stuff that make sense only for prod, and not
for tests (bundling files together, gzipping). On top of that, we already use GN
to manage test dependencies, see for example [1], where some JS files that are
needed by tests are added in the |data| section to ensure they are available
during testing, and [2] where those files are included in the test from C++.

[1]
https://cs.chromium.org/chromium/src/chrome/test/BUILD.gn?q=chrome/test/BUILD...
[2]
https://cs.chromium.org/chromium/src/chrome/test/base/v8_unit_test.cc?type=cs...

+                            "iron-test-helpers/mock-interactions.js"));
+      ASSERT_TRUE(base::ReadFileToString(mock_interactions_path,
+                                         &mock_interactions_js));
+      test_util_js.append(mock_interactions_js);
+
       base::FilePath test_file_path = test_data_dir.AppendASCII(filename);
       std::string test_js;
       ASSERT_TRUE(base::ReadFileToString(test_file_path, &test_js));
 
       test_util_js.append(test_js);
     }
 
     ASSERT_TRUE(content::ExecuteScript(guest_contents, test_util_js));
 
     if (!catcher.GetNextResult())
@@ skipping 856 matching lines @@
 IN_PROC_BROWSER_TEST_F(PDFExtensionTest, OpenFromFTP) {
   net::SpawnedTestServer ftp_server(
       net::SpawnedTestServer::TYPE_FTP, net::SpawnedTestServer::kLocalhost,
       base::FilePath(FILE_PATH_LITERAL("chrome/test/data/pdf")));
   ASSERT_TRUE(ftp_server.Start());
 
   GURL url(ftp_server.GetURL("/test.pdf"));
   ASSERT_TRUE(LoadPdf(url));
   EXPECT_EQ(base::ASCIIToUTF16("test.pdf"), GetActiveWebContents()->GetTitle());
 }