ios/web/web_state/ui/crw_wk_navigation_states.h - Issue 2950853002: Gracefully handle didCommitNavigation: call after didFinishNavigation:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_wk_navigation_states.h

Issue 2950853002: Gracefully handle didCommitNavigation: call after didFinishNavigation: (Closed)

Patch Set: Updated comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/crw_wk_navigation_states.h

diff --git a/ios/web/web_state/ui/crw_wk_navigation_states.h b/ios/web/web_state/ui/crw_wk_navigation_states.h

index 6052538b74ec2ac31cdc26c76c036f02f0193c55..35731ecb43a8079b033e833d0ec260ebe279885f 100644

--- a/ios/web/web_state/ui/crw_wk_navigation_states.h

+++ b/ios/web/web_state/ui/crw_wk_navigation_states.h

@@ -56,6 +56,9 @@ enum class WKNavigationState : int {

- (void)setState:(web::WKNavigationState)state

forNavigation:(WKNavigation*)navigation;

+// Returns state for a given |navigation| or NONE if navigation does not exist.

+- (web::WKNavigationState)stateForNavigation:(WKNavigation*)navigation;

// Removes given |navigation|. Fails if |navigation| does not exist.

// |navigation| can be null.

- (void)removeNavigation:(WKNavigation*)navigation;