Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2952083002: Remove unnecessary logic from UpdateScreen (Closed)

Created:
3 years, 6 months ago by kumarniranjan
Modified:
3 years, 6 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary logic from UpdateScreen This logic was added in an attempt to resolve incompatibilities with autoupdate_EndToEndTest, but it was not successful. This commit is mainly a revert of https://codereview.chromium.org/2894783003/ However, it preserves some useful functionality such as unit tests. BUG=chromium:710716 BUG=b:34385702 TEST=unit test Review-Url: https://codereview.chromium.org/2952083002 Cr-Commit-Position: refs/heads/master@{#481603} Committed: https://chromium.googlesource.com/chromium/src/+/4b80b10f3323a5d0d6a716f1b57c79559419ff31

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -265 lines) Patch
M chrome/browser/chromeos/login/screens/update_screen.h View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen.cc View 3 chunks +5 lines, -43 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen_unittest.cc View 5 chunks +42 lines, -164 lines 0 comments Download
M chrome/browser/chromeos/login/startup_utils.h View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/startup_utils.cc View 3 chunks +0 lines, -30 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
kumarniranjan
Hi Xiyuan, This is the new CL which had to be uploaded because I had ...
3 years, 6 months ago (2017-06-21 23:50:13 UTC) #2
xiyuan
lgtm
3 years, 6 months ago (2017-06-22 16:49:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2952083002/1
3 years, 6 months ago (2017-06-22 16:50:39 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 18:06:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4b80b10f3323a5d0d6a716f1b57c...

Powered by Google App Engine
This is Rietveld 408576698