Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2952903002: ChromeOS: Add support for Gaia v2 API to FakeGaia and screen handler. (Closed)

Created:
3 years, 6 months ago by Alexander Alekseev
Modified:
3 years, 5 months ago
Reviewers:
achuithb, msarda
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS: Add support for Gaia v2 API to FakeGaia and screen handler. This CL adds test support for Gaia V2 API and adds support for V2 to signin screen handler. BUG=709244 Review-Url: https://codereview.chromium.org/2952903002 Cr-Commit-Position: refs/heads/master@{#483218} Committed: https://chromium.googlesource.com/chromium/src/+/214d8372995dfe8ff136ee05209945ff4f09ed79

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 2

Patch Set 3 : Update after review #

Patch Set 4 : Fix tests #

Patch Set 5 : Fix build #

Patch Set 6 : Fix Easy bootstrap #

Patch Set 7 : Disable v2 by default #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M google_apis/gaia/fake_gaia.cc View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M google_apis/gaia/gaia_urls.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_urls.cc View 1 2 3 4 3 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 48 (30 generated)
Alexander Alekseev
Please review.
3 years, 6 months ago (2017-06-22 00:48:35 UTC) #2
achuithb
What do we do about testing API v2? https://codereview.chromium.org/2952903002/diff/20001/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right): https://codereview.chromium.org/2952903002/diff/20001/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc#newcode351 chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:351: params.SetString("chromeOSApiVersion", ...
3 years, 6 months ago (2017-06-22 01:00:03 UTC) #5
achuithb
lgtm
3 years, 6 months ago (2017-06-22 01:00:09 UTC) #6
Alexander Alekseev
> What do we do about testing API v2? This doesn't add any new functionality ...
3 years, 6 months ago (2017-06-22 01:08:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2952903002/40001
3 years, 6 months ago (2017-06-22 09:56:51 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/412679)
3 years, 6 months ago (2017-06-22 11:35:31 UTC) #16
Alexander Alekseev
msarda@chromium.org: Please review changes in google_apis/gaia/*
3 years, 6 months ago (2017-06-22 12:14:48 UTC) #20
msarda
lgtm
3 years, 6 months ago (2017-06-22 12:19:19 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2952903002/80001
3 years, 6 months ago (2017-06-22 12:30:19 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/453673)
3 years, 6 months ago (2017-06-22 13:47:56 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2952903002/80001
3 years, 6 months ago (2017-06-22 16:48:36 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/453829)
3 years, 6 months ago (2017-06-22 17:31:39 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2952903002/100001
3 years, 6 months ago (2017-06-22 18:37:36 UTC) #35
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/41a571aba88b7fa5cb477eea2f6795181951525b
3 years, 6 months ago (2017-06-22 19:49:01 UTC) #38
Wenzhao (Colin) Zang
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/2959523002/ by wzang@chromium.org. ...
3 years, 6 months ago (2017-06-23 22:31:07 UTC) #39
Alexander Alekseev
This CL did two things: enabled Gaia API v2 by default and added support for ...
3 years, 5 months ago (2017-06-28 22:48:43 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2952903002/120001
3 years, 5 months ago (2017-06-28 22:49:24 UTC) #45
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 00:23:49 UTC) #48
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/214d8372995dfe8ff136ee052099...

Powered by Google App Engine
This is Rietveld 408576698