|
|
Created:
3 years, 6 months ago by Alexander Alekseev Modified:
3 years, 5 months ago CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionChromeOS: Add support for Gaia v2 API to FakeGaia and screen handler.
This CL adds test support for Gaia V2 API and adds support for V2 to signin screen handler.
BUG=709244
Review-Url: https://codereview.chromium.org/2952903002
Cr-Commit-Position: refs/heads/master@{#483218}
Committed: https://chromium.googlesource.com/chromium/src/+/214d8372995dfe8ff136ee05209945ff4f09ed79
Patch Set 1 #Patch Set 2 : Rebased #
Total comments: 2
Patch Set 3 : Update after review #Patch Set 4 : Fix tests #Patch Set 5 : Fix build #Patch Set 6 : Fix Easy bootstrap #Patch Set 7 : Disable v2 by default #
Messages
Total messages: 48 (30 generated)
alemate@chromium.org changed reviewers: + achuith@chromium.org
Please review.
The CQ bit was checked by alemate@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
What do we do about testing API v2? https://codereview.chromium.org/2952903002/diff/20001/chrome/browser/ui/webui... File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right): https://codereview.chromium.org/2952903002/diff/20001/chrome/browser/ui/webui... chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:351: params.SetString("chromeOSApiVersion", "2"); Add a comment?
lgtm
> What do we do about testing API v2? This doesn't add any new functionality (we will add it later). And this goup of CLs doesn't modify Gaia API on our side. Also, we are using the same webview as for the V1, so all the tests should work. https://codereview.chromium.org/2952903002/diff/20001/chrome/browser/ui/webui... File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right): https://codereview.chromium.org/2952903002/diff/20001/chrome/browser/ui/webui... chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:351: params.SetString("chromeOSApiVersion", "2"); On 2017/06/22 01:00:02, achuithb wrote: > Add a comment? Done.
The CQ bit was checked by alemate@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by alemate@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org Link to the patchset: https://codereview.chromium.org/2952903002/#ps40001 (title: "Update after review")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by alemate@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
alemate@chromium.org changed reviewers: + msarda@chromium.org
msarda@chromium.org: Please review changes in google_apis/gaia/*
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by alemate@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org, msarda@chromium.org Link to the patchset: https://codereview.chromium.org/2952903002/#ps80001 (title: "Fix build")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by alemate@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by alemate@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org, msarda@chromium.org Link to the patchset: https://codereview.chromium.org/2952903002/#ps100001 (title: "Fix Easy bootstrap")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 100001, "attempt_start_ts": 1498156630441580, "parent_rev": "77dc24354a694fff6a9f9a6e270ae05b4f604f51", "commit_rev": "41a571aba88b7fa5cb477eea2f6795181951525b"}
Message was sent while issue was closed.
Description was changed from ========== ChromeOS: Enable Gaia v2 API by default. BUG=709244 ========== to ========== ChromeOS: Enable Gaia v2 API by default. BUG=709244 Review-Url: https://codereview.chromium.org/2952903002 Cr-Commit-Position: refs/heads/master@{#481630} Committed: https://chromium.googlesource.com/chromium/src/+/41a571aba88b7fa5cb477eea2f67... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/41a571aba88b7fa5cb477eea2f67...
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/2959523002/ by wzang@chromium.org. The reason for reverting is: Will re-land after the Gaia v2 API is completely ready. For now it shows 404 error. This also affects the user pod placement, Please see crbug.com/736467.
Message was sent while issue was closed.
Description was changed from ========== ChromeOS: Enable Gaia v2 API by default. BUG=709244 Review-Url: https://codereview.chromium.org/2952903002 Cr-Commit-Position: refs/heads/master@{#481630} Committed: https://chromium.googlesource.com/chromium/src/+/41a571aba88b7fa5cb477eea2f67... ========== to ========== ChromeOS: Enable Gaia v2 API by default. BUG=709244 Review-Url: https://codereview.chromium.org/2952903002 Cr-Commit-Position: refs/heads/master@{#481630} Committed: https://chromium.googlesource.com/chromium/src/+/41a571aba88b7fa5cb477eea2f67... ==========
Description was changed from ========== ChromeOS: Enable Gaia v2 API by default. BUG=709244 Review-Url: https://codereview.chromium.org/2952903002 Cr-Commit-Position: refs/heads/master@{#481630} Committed: https://chromium.googlesource.com/chromium/src/+/41a571aba88b7fa5cb477eea2f67... ========== to ========== ChromeOS: Add support for Gaia v2 API to FakeGaia and screen handler. This CL adds test support for Gaia V2 API and adds support for V2 to signin screen handler. BUG=709244 ==========
This CL did two things: enabled Gaia API v2 by default and added support for it to tests and screen handler. Let's land them separately. So I left only tests and screen handler changes here.
The CQ bit was checked by alemate@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org, msarda@chromium.org Link to the patchset: https://codereview.chromium.org/2952903002/#ps120001 (title: "Disable v2 by default")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 120001, "attempt_start_ts": 1498690132605180, "parent_rev": "d5dfcdb0f4ef632fc90a53e02796f72d8d81f657", "commit_rev": "214d8372995dfe8ff136ee05209945ff4f09ed79"}
Message was sent while issue was closed.
Description was changed from ========== ChromeOS: Add support for Gaia v2 API to FakeGaia and screen handler. This CL adds test support for Gaia V2 API and adds support for V2 to signin screen handler. BUG=709244 ========== to ========== ChromeOS: Add support for Gaia v2 API to FakeGaia and screen handler. This CL adds test support for Gaia V2 API and adds support for V2 to signin screen handler. BUG=709244 Review-Url: https://codereview.chromium.org/2952903002 Cr-Commit-Position: refs/heads/master@{#483218} Committed: https://chromium.googlesource.com/chromium/src/+/214d8372995dfe8ff136ee052099... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/chromium/src/+/214d8372995dfe8ff136ee052099... |