Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: net/dns/host_cache_unittest.cc

Issue 2953483003: Add HostCachePersistenceManager for Cronet (Closed)
Patch Set: move constant Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/dns/host_cache.cc ('k') | net/log/net_log_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/dns/host_cache_unittest.cc
diff --git a/net/dns/host_cache_unittest.cc b/net/dns/host_cache_unittest.cc
index 66c0faae5e3b1a3f2a9291e94bcd5b401b0ccc14..f1ac9844b7800b5d7e1d7575ac8257e14095db99 100644
--- a/net/dns/host_cache_unittest.cc
+++ b/net/dns/host_cache_unittest.cc
@@ -704,8 +704,8 @@ TEST(HostCacheTest, SerializeAndDeserialize) {
// Advance to t=12, ansd serialize the cache.
now += base::TimeDelta::FromSeconds(7);
- std::unique_ptr<base::ListValue> serialized_cache =
- cache.GetAsListValue(/*include_staleness=*/false);
+ base::ListValue serialized_cache;
+ cache.GetAsListValue(&serialized_cache, /*include_staleness=*/false);
HostCache restored_cache(kMaxCacheEntries);
// Add entries for "foobar3.com" and "foobar4.com" to the cache before
@@ -720,7 +720,7 @@ TEST(HostCacheTest, SerializeAndDeserialize) {
EXPECT_TRUE(restored_cache.Lookup(key4, now));
EXPECT_EQ(2u, restored_cache.size());
- restored_cache.RestoreFromListValue(*serialized_cache);
+ restored_cache.RestoreFromListValue(serialized_cache);
HostCache::EntryStaleness stale;
« no previous file with comments | « net/dns/host_cache.cc ('k') | net/log/net_log_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698