Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2954473003: Enable apple touch icons to be used with bookmark apps disabled. (Closed)

Created:
3 years, 6 months ago by benwells
Modified:
3 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable apple touch icons to be used with bookmark apps disabled. There is no reason to restrict use of these icons when bookmark apps are disabled. BUG=735926 Review-Url: https://codereview.chromium.org/2954473003 Cr-Commit-Position: refs/heads/master@{#481625} Committed: https://chromium.googlesource.com/chromium/src/+/3f4961b60acdb71ef7a00b3ff67cc89b90b2f95c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M chrome/renderer/web_apps.cc View 3 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
benwells
After updating a bazillion files to use a function in comon, I realised this wasn't ...
3 years, 6 months ago (2017-06-22 13:03:27 UTC) #3
Lei Zhang
lgtm Even better!
3 years, 6 months ago (2017-06-22 18:14:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954473003/1
3 years, 6 months ago (2017-06-22 18:14:46 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 19:24:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3f4961b60acdb71ef7a00b3ff67c...

Powered by Google App Engine
This is Rietveld 408576698