Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Issue 2954523002: fix #27259, implement covariance checking for strong mode and DDC (Closed)
Patch Set: merged and fix an analysis error Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/dart/element/type.dart ('k') | pkg/analyzer/lib/src/generated/type_system.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/resolver.dart
diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart
index e2c839602f37b32f032c86fe00755fe53031bf37..3500d4a3d96cfc77daf03d3ed9eab30674f53663 100644
--- a/pkg/analyzer/lib/src/generated/resolver.dart
+++ b/pkg/analyzer/lib/src/generated/resolver.dart
@@ -6515,10 +6515,10 @@ class ResolverVisitor extends ScopedVisitor {
!FunctionTypeImpl.relate(
expectedClosureType,
staticClosureType,
- (DartType t, DartType s, _, __) =>
- (t as TypeImpl).isMoreSpecificThan(s),
+ (s, t) => true,
new TypeSystemImpl(typeProvider).instantiateToBounds,
- returnRelation: (s, t) => true)) {
+ parameterRelation: (t, s) =>
+ (t.type as TypeImpl).isMoreSpecificThan(s.type))) {
return;
}
// set propagated type for the closure
« no previous file with comments | « pkg/analyzer/lib/src/dart/element/type.dart ('k') | pkg/analyzer/lib/src/generated/type_system.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698